Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-cpp 1.11.0 #140216

Merged

Conversation

chenrui333
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes
## v1.11.0 release

Release of core packages

  • opentelemetry-api
  • opentelemetry-sdk

and exporter packages:

  • opentelemetry-exporter-otlp (gRPC + HTTP/JSON)
  • opentelemetry-exporter-prometheus

What's Changed

Notes

  • Logs are declared as stable in this release.

New Contributors

Full Changelog: open-telemetry/opentelemetry-cpp@v1.10.0...v1.11.0

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` boost Boost use is a significant feature of the PR or issue labels Aug 22, 2023
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 23, 2023
@bayandin bayandin force-pushed the bump-opentelemetry-cpp-1.11.0 branch 2 times, most recently from 64c3949 to f1aa831 Compare August 23, 2023 07:10
@bayandin bayandin added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. test failure CI fails while running the test-do block and removed CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Aug 23, 2023
@bayandin
Copy link
Member

The test fails with

  /usr/local/include/absl/meta/type_traits.h:92:27: error: reference to 'is_trivially_destructible' is ambiguous
                      absl::is_trivially_destructible<T>::value> {};
                            ^
  /usr/local/Cellar/opentelemetry-cpp/1.11.0/include/opentelemetry/nostd/./internal/absl/types/../utility/../base/internal/../../meta/type_traits.h:298:8: note: candidate found by name lookup is 'absl::otel_v1::is_trivially_destructible'
  struct is_trivially_destructible
         ^
  /usr/local/include/absl/meta/type_traits.h:63:8: note: candidate found by name lookup is 'absl::lts_20230125::is_trivially_destructible'
  struct is_trivially_destructible;
         ^

@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the stale No recent activity label Aug 25, 2023
@chenrui333 chenrui333 added help wanted Task(s) needing PRs from the community or maintainers and removed stale No recent activity labels Aug 25, 2023
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 2, 2023
system ENV.cxx, "test.cc", "-std=c++17",
"-DHAVE_CPP_STDLIB",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This combined with the WITH_STL cmake option above should fix it. Without them, opentelemetry-cpp uses its own STL implementation, which depends on an internal, bundled abseil. That's not compatible with the abseil that protobuf uses.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, it was a bit too early to say that. Now we've got another problem 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work with Big Sur's libc++ for some reason. Let's not use WITH_STL then. In that case we can still fix this by defining HAVE_ABSEIL.

Failure on Big Sur, for reference
  In file included from /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/exporters/otlp/src/otlp_http_client.cc:4:
  In file included from /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_client.h:8:
  In file included from /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/api/include/opentelemetry/nostd/variant.h:9:
  /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/api/include/opentelemetry/std/variant.h:61:8: error: call to implicitly-deleted copy constructor of 'std::variant'
    auto v      = t;
         ^        ~
  /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/api/include/opentelemetry/std/variant.h:113:10: note: in instantiation of function template specialization 'opentelemetry::nostd::(anonymous class)::operator() &>' requested here
    return get_type(v);
           ^
  /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/exporters/otlp/src/otlp_http_client.cc:733:31: note: in instantiation of function template specialization 'opentelemetry::nostd::get' requested here
          opentelemetry::nostd::get(session);
                                ^
  /Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/c++/v1/variant:1204:3: note: explicitly defaulted function was implicitly deleted here
    variant(const variant&) = default;
    ^
  /Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/c++/v1/variant:1173:7: note: copy constructor of 'variant' is implicitly deleted because base class '__sfinae_ctor_base<__all, is_copy_constructible_v>::value, __all, is_move_constructible_v>::value>' has a deleted copy constructor
      : private __sfinae_ctor_base<
        ^
  /Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/c++/v1/__tuple:515:3: note: '__sfinae_ctor_base' has been explicitly marked deleted here
    __sfinae_ctor_base(__sfinae_ctor_base const&) = delete;
    ^
  In file included from /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/exporters/otlp/src/otlp_http_client.cc:4:
  In file included from /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_client.h:8:
  In file included from /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/api/include/opentelemetry/nostd/variant.h:9:
  /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/api/include/opentelemetry/std/variant.h:61:8: error: call to implicitly-deleted copy constructor of 'std::variant'
    auto v      = t;
         ^        ~
  /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/api/include/opentelemetry/std/variant.h:113:10: note: in instantiation of function template specialization 'opentelemetry::nostd::(anonymous class)::operator() &>' requested here
    return get_type(v);
           ^
  /tmp/opentelemetry-cpp-20230902-7122-1l8y9yb/opentelemetry-cpp-1.11.0/exporters/otlp/src/otlp_http_client.cc:741:46: note: in instantiation of function template specialization 'opentelemetry::nostd::get' requested here
    addSession(std::move(opentelemetry::nostd::get(session)));
                                               ^
  /Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/c++/v1/variant:1204:3: note: explicitly defaulted function was implicitly deleted here
    variant(const variant&) = default;
    ^
  /Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/c++/v1/variant:1173:7: note: copy constructor of 'variant' is implicitly deleted because base class '__sfinae_ctor_base<__all, is_copy_constructible_v>::value, __all, is_move_constructible_v>::value>' has a deleted copy constructor
      : private __sfinae_ctor_base<
        ^
  /Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/c++/v1/__tuple:515:3: note: '__sfinae_ctor_base' has been explicitly marked deleted here
    __sfinae_ctor_base(__sfinae_ctor_base const&) = delete;
    ^

@ZhongRuoyu ZhongRuoyu added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Sep 2, 2023
- opentelemetry-cpp: unversioned grpc and protobuf
- opentelemetry-cpp: depend on abseil; remove noop WITH_LOGS_PREVIEW=ON
- opentemetry-cpp: define `HAVE_ABSEIL` in test

Co-authored-by: Alexander Bayandin <alexander@bayandin.dev>
Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
@ZhongRuoyu ZhongRuoyu added ready to merge PR can be merged once CI is green and removed help wanted Task(s) needing PRs from the community or maintainers test failure CI fails while running the test-do block CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Sep 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 2, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 2, 2023
Merged via the queue into Homebrew:master with commit ee9736d Sep 2, 2023
12 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2023
@chenrui333 chenrui333 deleted the bump-opentelemetry-cpp-1.11.0 branch January 22, 2024 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
boost Boost use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants