Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickhouse-cpp: use vendored cityhash #129222

Merged

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Use the vendored version (1.0.2) of cityhash because newer versions break hash compatibility. See: ClickHouse/clickhouse-cpp#301 (comment)

Use the vendored version (1.0.2) of `cityhash` because newer versions
break hash compatibility. See:
  ClickHouse/clickhouse-cpp#301 (comment)
@ZhongRuoyu ZhongRuoyu force-pushed the clickhouse-cpp-vendored-cityhash branch from 632f740 to d1a4d4a Compare April 24, 2023 20:37
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 24, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 24, 2023
Merged via the queue into Homebrew:master with commit 666b7ad Apr 24, 2023
@ZhongRuoyu ZhongRuoyu deleted the clickhouse-cpp-vendored-cityhash branch April 24, 2023 22:44
@github-actions github-actions bot added the outdated PR was locked due to age label May 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants