Skip to content

Commit

Permalink
node@14: update 14.15.4 bottle.
Browse files Browse the repository at this point in the history
  • Loading branch information
@fxcoudert
fxcoudert committed Jan 6, 2021
1 parent 9e25ddd commit 700c6c1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Formula/node@14.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class NodeAT14 < Formula
bottle do
cellar :any
sha256 "8ea277e44a9caf1ec786e6d587a1f354800a7701ec36a013a677e67dcbbf1ffd" => :big_sur
sha256 "7692419a90f930e258d15e8a2935c39c09468a874b4b125527044c926dae03cf" => :arm64_big_sur
sha256 "c7dad357f47ccca70b7f7e389df005409859bdc382421bae08672a5f07913308" => :catalina
sha256 "719ddeee6070d1afdac6d04c1e4977e175cc1dfec3e19db5c8c75cacfc13de6b" => :mojave
end
Expand Down

5 comments on commit 700c6c1

@zac1st1k
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fxcoudert, May I know where the arm64 binary come from? It seems Node didn't ship arm64 binary for 14 officially. Cheers.

@SMillerDev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All homebrew software is compiled from source. So this binary was also compiled from source.

@zac1st1k
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SMillerDev
Node cannot be compiled on arm64 before nodejs/node#36161
until 11th, April the arm64 support was cherry picked to node 14 nodejs/node#38051 (comment)
but this commit was built on 7th January. I am a bit confused how is that even possible? Could you please share more context?

@Bo98
Copy link
Member

@Bo98 Bo98 commented on 700c6c1 Sep 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compiler error mentioned in that issue is building OpenSSL, but we build OpenSSL separately.

There were indeed some v8 fixes that came later, but the absence of them didn't actually break the compile.

@zac1st1k
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanations! @SMillerDev @Bo98
I really appreciate that.

Please sign in to comment.