Skip to content

feat: update codegen api and types #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2021

Conversation

Himenon
Copy link
Owner

@Himenon Himenon commented Feb 1, 2021

Summary

  • Enhanced type of return value of ApiClient request to DI.

BREAKING_CHANGE

  • option.makeApiClient -> option.rewriteCodeAfterTypeDeclaration

Test Plan

@@ -11,7 +11,9 @@ export { Converter };

export interface Params {
entryPoint: string;
option?: Partial<Converter.v3.Option>;
option?: {
rewriteCodeAfterTypeDeclaration?: Converter.v3.Generator.RewriteCodeAfterTypeDeclaration;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BREAKING

@Himenon Himenon merged commit 1c6e748 into main Feb 1, 2021
@Himenon Himenon deleted the feat/update-codegen-api-and-types branch February 1, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant