fixed bugs

Author: Hillary520

README.md

@@ -1,51 +1,54 @@
-# System Monitor
 
-This Python script is a simple system monitor that displays CPU, memory, and network bandwidth usage in a terminal. It uses the `psutil` library to retrieve system information.
+---
 
-## Features
-
-- Displays CPU and memory usage in a visual format using hash (`#`) and hyphen (`-`) characters.
-- Monitors network bandwidth usage and shows the received, sent, and total data transfer rates.
-- Continuously updates the output every 0.5 seconds.
-- Clears the terminal screen before displaying the updated output.
-
-## Requirements
+# Python System Monitor
 
-- Python 3.x
-- `psutil` library (install with `pip install psutil`)
+A terminal-based system monitor application built with Python and the `curses` library. This application provides real-time monitoring of CPU usage, memory usage, network bandwidth, system information, and running processes.
 
-## Usage
+## Features
 
-1. Clone or download the repository.
-2. Open a terminal and navigate to the project directory.
-3. Run the script with `python system_monitor.py`.
-4. The output will be displayed in the terminal, updating every 0.5 seconds.
-5. Press `Ctrl+C` to exit the program.
+- **CPU Usage**: Displays overall CPU usage as well as usage per core.
+- **Memory Usage**: Displays current memory and swap usage.
+- **Network Usage**: Shows network bandwidth usage.
+- **System Information**: Provides details about the operating system, Python version, hostname, IP address, CPU cores, RAM, and system uptime.
+- **Running Processes**: Lists top running processes by memory usage with the ability to highlight and kill processes using the keyboard and mouse.
 
-## Todo
+## Prerequisites
 
-The following features can be added to enhance the system monitor:
+- Python 3.6 or higher
+- `psutil` library
 
-### System Information
+## Installation
 
-Add functionality to display additional system information such as:
+1. Clone the repository:
+    ```sh
+    git clone https://github.com/Hillary520/python_system_monitor.git
+    cd python_system_monitor
+    ```
 
-- Operating system name and version
-- System uptime
-- CPU model and number of cores
-- Total and available RAM
+2. Install the required Python libraries:
+    ```sh
+    pip install psutil
+    ```
 
-### Running Processes
+## Usage
 
-Implement a feature to display a list of currently running processes on the system, including:
+Run the main script to start the system monitor:
+```sh
+python3 main.py
+```
 
-- Process name
-- Process ID (PID)
-- CPU and memory usage for each process
+## Modules
 
-You can use the `psutil.process_iter()` function to iterate over all running processes and retrieve the necessary information.
+- `cpu_monitor.py`: Contains the `CPUMonitor` class to get CPU usage information.
+- `memory_monitor.py`: Contains the `MemoryMonitor` class to get memory and swap usage.
+- `network_monitor.py`: Contains the `NetworkMonitor` class to get network bandwidth usage.
+- `system_info.py`: Contains the `SystemInfo` class to get system information.
+- `processes.py`: Contains the `ProcessMonitor` class to get a list of running processes.
 
-## Contributing
+## Controls
 
-Contributions are welcome! If you find any issues or have ideas for improvements, please open an issue or submit a pull request.
+- **Arrow Keys**: Navigate through the list of processes.
+- **Mouse Click**: Click to select/highlight a process.
+- **K**: Kill the highlighted process.
 

cpu_monitor.py

@@ -20,4 +20,4 @@ def _format_usage(self, cpu):
     def _format_core_usage(self, core_idx, core):
         core_percent = core / 100.0
         core_visual = '#' * int(core_percent * self.bars) + '-' * (self.bars - int(core_percent * self.bars))
-        return f"Core {core_idx}: [{core_visual}] {core:.2f}%"
+        return f"Core {core_idx}: [{core_visual}] {core:.2f}%"

main.py

@@ -124,4 +124,4 @@ def print_processes(processes_output, process_start):
         print("\nExiting...")
 
 if __name__ == "__main__":
-    curses.wrapper(main)
+    curses.wrapper(main)

memory_monitor.py

@@ -20,4 +20,4 @@ def get_swap_usage(self):
     def _format_usage_swap(self, swap):
         swap_percent = swap / 100.0
         swap_visual = '#' * int(swap_percent * self.bars) + '-' * (self.bars - int(swap_percent * self.bars))
-        return f"Swap: [{swap_visual}] {swap:.2f}%"
+        return f"Swap: [{swap_visual}] {swap:.2f}%"

network_monitor.py

@@ -19,4 +19,4 @@ def get_bandwidth_usage(self):
         sent_kb = new_sent / 1024
         total_kb = (new_received + new_sent) / 1024
 
-        return f"Received: {received_kb:.2f} KB | Sent: {sent_kb:.2f} KB | Total: {total_kb:.2f} KB"
+        return f"Received: {received_kb:.2f} KB | Sent: {sent_kb:.2f} KB | Total: {total_kb:.2f} KB"

processes.py

@@ -9,4 +9,4 @@ def get_running_processes(self, num_processes=10):
             except (psutil.NoSuchProcess, psutil.AccessDenied, psutil.ZombieProcess):
                 continue
         sorted_processes = sorted(processes, key=lambda p: p['memory_percent'], reverse=True)
-        return sorted_processes[:num_processes]
+        return sorted_processes[:num_processes]

system_info.py

@@ -116,5 +116,4 @@ def _parse_health_info(self, health_info, key):
         return health_info.split(f"{key} = ")[1].split('\n')[0].strip()
 
     def _parse_battery_report(self, report, key):
-        return report.split(f'{key}')[1].split('<td>')[1].split(' mWh')[0].replace(',', '')
-
+        return report.split(f'{key}')[1].split('<td>')[1].split(' mWh')[0].replace(',', '')