Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX]: login flow not working when redirected from store tab #3896

Merged
merged 1 commit into from
Aug 3, 2024
Merged

[FIX]: login flow not working when redirected from store tab #3896

merged 1 commit into from
Aug 3, 2024

Conversation

imLinguin
Copy link
Member

This bug affected only amazon and gog.
The WebView never triggered auth flow when it was required.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Aug 3, 2024
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC, Etaash-mathamsetty and Nocccer and removed request for a team August 3, 2024 16:54
Etaash-mathamsetty
Etaash-mathamsetty approved these changes Aug 3, 2024
View reviewed changes
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll test soon. regular login works, im not sure what u mean by "redirected from store tab" though

@imLinguin
Copy link
Member Author

imLinguin commented Aug 3, 2024 •
edited
Loading

#3897

@Etaash-mathamsetty Etaash-mathamsetty merged commit e50bea7 into main Aug 3, 2024
8 of 9 checks passed
@Etaash-mathamsetty Etaash-mathamsetty deleted the fix/loginflow branch August 3, 2024 19:04
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Etaash-mathamsetty Etaash-mathamsetty Etaash-mathamsetty approved these changes

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imLinguin @Etaash-mathamsetty