Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] cleanup discord rpc on launch failures #3888

Merged
merged 1 commit into from
Jul 28, 2024
Merged

[Fix] cleanup discord rpc on launch failures #3888

merged 1 commit into from
Jul 28, 2024

Conversation

imLinguin
Copy link
Member

Fixes issues with hanging rpc client.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 28, 2024
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC, Etaash-mathamsetty and Nocccer and removed request for a team July 28, 2024 10:33
@imLinguin imLinguin changed the title fix: cleanup discord rpc on launch failures [Fix] cleanup discord rpc on launch failures Jul 28, 2024
Etaash-mathamsetty
Etaash-mathamsetty approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@imLinguin imLinguin merged commit 5fc4c8d into main Jul 28, 2024
9 checks passed
@imLinguin imLinguin deleted the fix/rpc-cleanup branch July 28, 2024 15:55
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Etaash-mathamsetty Etaash-mathamsetty Etaash-mathamsetty approved these changes

@arielj arielj Awaiting requested review from arielj arielj was automatically assigned from Heroic-Games-Launcher/development

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imLinguin @Etaash-mathamsetty