Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scroll to categories dropdown when too many categories #3857

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jul 10, 2024

This PR fixes this issue reported in Discord https://discord.com/channels/812703221789097985/1253620445224112159/1253620445224112159

when adding categories, a user can add many categories and not fit the screen when opening the dropdown. This adds a scroll and a height limit.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 10, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team July 10, 2024 22:13
@arielj arielj merged commit dfa48dc into main Jul 11, 2024
8 of 9 checks passed
@arielj arielj deleted the fix-categories-dropdown-too-tall branch July 11, 2024 00:55
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants