Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Prevent uninstalling a game while it's running #3779

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented May 22, 2024

This PR disables the "Uninstall" button while a game is running so it cannot be uninstalled by mistake.

Other games can be uninstalled (though we still have the limitation if not uninstalling an Epic game while another Epic game is being installed, but that's unrelated to this fix).

Apart from disabling the buttons, I also made the Uninstall dialog no-op when the game is playing, so if we add an uninstall button and we forget to disable it, it still won't allow the user to uninstall the game while it's running.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team May 22, 2024 21:46
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 30, 2024
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, i will test it later

@Etaash-mathamsetty Etaash-mathamsetty force-pushed the disable-uninstall-while-playing branch from d13b412 to aacd99c Compare June 14, 2024 21:51
@Etaash-mathamsetty
Copy link
Member

looks like it's working

@arielj arielj merged commit 3ed2f38 into main Jul 10, 2024
9 checks passed
@arielj arielj deleted the disable-uninstall-while-playing branch July 10, 2024 22:16
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants