-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Remove isMac check for 32 bit dxvk #3768
Conversation
I don't understand the reason of this change (I'm not versed in how all this dxvk stuff works and even less with mac so I don't understand the topic) I see some comments about this in discord but I don't know about this, how can I test this on my mac? what should I look for? |
run a 32 bit game that uses d3d, then check if it uses dxvk |
i just tried with Flatout and the game works in the main branch but fails to launch with this branch I'm attaching both logs: for both cases I'm using wine-crossover 23 and in both cases it's creating a new prefix maybe this change is fine for crossover but not for wine-crossover? I don't have the paid crossover to test it though 1207658693-errors.log EDIT: I tried with the latest wine-staging 9.11 that can be installed with heroic and I have the same error when launching the game with this branch and works fine in main |
Seems like moltenvk doesn't support enough features to run dxvk? |
Only There’s not many 32Bit DirectX 10 & DirectX11 games. |
Tested flatout again with this PR and reinstalling the game, new prefix, new everything, and it's now working. |
I due to how many projects directly use DXVK-macOS incorrectly I’d recently repackaged the latest package and removed incompatible dlls, this could have changed your results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
32 bit dlls can run on mac os thanks to the wow64 implemented in crossover (and upstream wine).
Use the following Checklist if you have changed something on the Backend or Frontend: