Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Remove isMac check for 32 bit dxvk #3768

Merged
merged 1 commit into from
Aug 9, 2024
Merged

[FIX] Remove isMac check for 32 bit dxvk #3768

merged 1 commit into from
Aug 9, 2024

Conversation

Etaash-mathamsetty
Copy link
Member

32 bit dlls can run on mac os thanks to the wow64 implemented in crossover (and upstream wine).

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@Etaash-mathamsetty Etaash-mathamsetty changed the title [FIX] remove isMac check for 32 bit dxvk [FIX] Remove isMac check for 32 bit dxvk May 18, 2024
@Etaash-mathamsetty Etaash-mathamsetty added the pr:ready-for-review Feature-complete, ready for the grind! :P label May 28, 2024
@Etaash-mathamsetty Etaash-mathamsetty requested a review from arielj July 4, 2024 05:03
@arielj
Copy link
Collaborator

arielj commented Jul 11, 2024

I don't understand the reason of this change (I'm not versed in how all this dxvk stuff works and even less with mac so I don't understand the topic)

I see some comments about this in discord but I don't know about this, how can I test this on my mac? what should I look for?

@Etaash-mathamsetty
Copy link
Member Author

Etaash-mathamsetty commented Jul 11, 2024

I don't understand the reason of this change (I'm not versed in how all this dxvk stuff works and even less with mac so I don't understand the topic)

I see some comments about this in discord but I don't know about this, how can I test this on my mac? what should I look for?

run a 32 bit game that uses d3d, then check if it uses dxvk
try flatout if you own that

@arielj
Copy link
Collaborator

arielj commented Jul 13, 2024

i just tried with Flatout and the game works in the main branch but fails to launch with this branch

I'm attaching both logs: ...-errors.log is the run with this branch, ...-lastPlay.log is the one using main

for both cases I'm using wine-crossover 23 and in both cases it's creating a new prefix

maybe this change is fine for crossover but not for wine-crossover? I don't have the paid crossover to test it though

1207658693-errors.log
1207658693-lastPlay.log

EDIT: I tried with the latest wine-staging 9.11 that can be installed with heroic and I have the same error when launching the game with this branch and works fine in main

@Etaash-mathamsetty
Copy link
Member Author

i just tried with Flatout and the game works in the main branch but fails to launch with this branch

I'm attaching both logs: ...-errors.log is the run with this branch, ...-lastPlay.log is the one using main

for both cases I'm using wine-crossover 23 and in both cases it's creating a new prefix

maybe this change is fine for crossover but not for wine-crossover? I don't have the paid crossover to test it though

1207658693-errors.log
1207658693-lastPlay.log

EDIT: I tried with the latest wine-staging 9.11 that can be installed with heroic and I have the same error when launching the game with this branch and works fine in main

Seems like moltenvk doesn't support enough features to run dxvk?

@Gcenx
Copy link
Contributor

Gcenx commented Jul 27, 2024

Only d3d10core.dll & d3d11.dll from DXVK-macOS are usable. I’d pushed a repackaged release that only contains the working dlls.

There’s not many 32Bit DirectX 10 & DirectX11 games.

@arielj
Copy link
Collaborator

arielj commented Jul 29, 2024

Tested flatout again with this PR and reinstalling the game, new prefix, new everything, and it's now working.

@Gcenx
Copy link
Contributor

Gcenx commented Jul 31, 2024

Tested flatout again with this PR and reinstalling the game, new prefix, new everything, and it's now working.

I due to how many projects directly use DXVK-macOS incorrectly I’d recently repackaged the latest package and removed incompatible dlls, this could have changed your results.

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flavioislima flavioislima merged commit 0ed4fd2 into main Aug 9, 2024
9 checks passed
@flavioislima flavioislima deleted the mac-dxvk branch August 9, 2024 16:15
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants