-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Improve the "Move Game" experience a bit #3648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, I couldn't test the windows one cause I don't have windows
a171216
to
675c58a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
I can't test the windows one though, and I feel like we are doing more work than needed sending so many updates to the frontend but I think that's something to refactor in another PR anyway (I imagine something like capturing the last file and progress for every data but only send messages to the frontend every X milliseconds? something like that)
We should definitely modify how the progress is presented, I agree. I think going for a general "Here's how far along the entire move process is" progress bar (as Steam does it, for example), and switching to per-file progress if one takes more than a couple seconds to transfer, would be the best option
I've tested this in a Windows VM (actually worked out the Windows changes before the Linux ones) and it works fine. Filenames are a little weird sometimes (it sometimes shows a relative path and sometimes an absolute one), but that's robocopy's fault as far as I can tell |
Nothing too significant, just 3 quick improvements to the "Move Game" functionality:
if (percent)
checks, which erroneously filtered out the case where percent might be 0 (aka we just started copying a new file)rsync
to delete source/old files after they're copied to the new locationprogress
property of the progress update are now correct (percent
should be a number instead of a string, andeta
andbytes
were missing entirely)eta
andbytes
still aren't populated on Windows (robocopy
simply doesn't give us this info), so I've not displayed them anywhere yetsendFrontendMessage
, a PR for that should land alongside this oneI'm still not entirely happy with this function (from a user's point of view I'd expect it to give me a progress bar for the entire move operation, knowing that one specific file is being moved is not too helpful), but that'd be a more complex refactor
Use the following Checklist if you have changed something on the Backend or Frontend: