Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH]: update electron #3628

Merged
merged 3 commits into from
Mar 22, 2024
Merged

[TECH]: update electron #3628

merged 3 commits into from
Mar 22, 2024

Conversation

imLinguin
Copy link
Member

Updated electron to 29.1.3

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@imLinguin imLinguin added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 14, 2024
@imLinguin imLinguin requested review from a team, arielj, flavioislima, CommandMC, Etaash-mathamsetty and Nocccer and removed request for a team March 14, 2024 14:03
@imLinguin imLinguin added this to the 2.13.1 milestone Mar 14, 2024
@imLinguin imLinguin force-pushed the tech/electron-update branch from 2fdbce9 to 7ae4d88 Compare March 14, 2024 16:50
arielj
arielj approved these changes Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@arielj arielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this a bit and it seems to work fine, at least the things I tested

@JakobDev JakobDev mentioned this pull request Mar 20, 2024
Closed
@Etaash-mathamsetty Etaash-mathamsetty merged commit 199e09c into Heroic-Games-Launcher:main Mar 22, 2024
9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Etaash-mathamsetty Etaash-mathamsetty Etaash-mathamsetty approved these changes

@arielj arielj arielj approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
2.13.1
Development

Successfully merging this pull request may close these issues.
3 participants
@imLinguin @arielj @Etaash-mathamsetty