Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Wine/Proton-GE-latest not updatable after Heroic relaunch or Wine manager refresh #3620

Merged

Conversation

matteobtt
Copy link
Contributor

Wine-GE-latest or Proton-GE-latest updates do not work because of two problems:

  1. When Heroic starts up, new Wine/Proton updates are checked in background but the user is not notified, you have to go to "Wine Manager" screen to see them, unfortunately the update button disappears the next time you restart Heroic or if you reload the versions list and so they go unnoticed.
  2. The update fails because the Wine installation folder is renamed with "_backup" suffix (to restore it in case of problems) and the unzip does not find the original folder where to install the new version.

I fixed it by preventing the override of "hasUpdate" field in the wine-downloader-info.json file until Wine is updated and recreating the Wine folder after the backup.
For me I would show somewhere an indicator for new Wine updates at Heroic startup.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima
Copy link
Member

flavioislima commented Mar 7, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@matteobtt
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 9, 2024
@imLinguin imLinguin added this to the 2.13.1 milestone Mar 14, 2024
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing to Heroic :D

@flavioislima flavioislima merged commit 894abca into Heroic-Games-Launcher:main Mar 31, 2024
9 checks passed
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants