Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Apply top padding only to external link warning dialog #3550

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Feb 11, 2024

There was a regression with this change bda0871#diff-d9b11fef9fc96a7cf2707aa13652ab1309131d88dcdba70f00cd97fcccc25830R16 causing all dialogs to have extra top padding.

Causing this visual glitch:
image

This PR fixes that by applying the padding only to the external link warning dialog.

I also changed the hardcoded 20px to the css property that's used at the bottom so it's more theme-friendly.

(we should re-write this component in the future, it's using margin properties as padding)


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 11, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team February 11, 2024 13:35
Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flavioislima flavioislima merged commit 37c1a1d into main Feb 11, 2024
9 checks passed
@flavioislima flavioislima deleted the fix-dialog-top-overflow branch February 11, 2024 13:43
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants