[FIX] Apply top padding only to external link warning dialog #3550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression with this change bda0871#diff-d9b11fef9fc96a7cf2707aa13652ab1309131d88dcdba70f00cd97fcccc25830R16 causing all dialogs to have extra top padding.
Causing this visual glitch:
This PR fixes that by applying the padding only to the external link warning dialog.
I also changed the hardcoded
20px
to the css property that's used at the bottom so it's more theme-friendly.(we should re-write this component in the future, it's using margin properties as padding)
Use the following Checklist if you have changed something on the Backend or Frontend: