Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix/UX] Check config before calling autoupdater #3530

Merged
merged 1 commit into from
Feb 8, 2024
Merged

[Fix/UX] Check config before calling autoupdater #3530

merged 1 commit into from
Feb 8, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Feb 6, 2024

This PR fixes #3524

We were always calling autoUpdater.checkForUpdates even if the setting was turned off.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Feb 6, 2024
@arielj arielj added this to the 2.13.0 milestone Feb 6, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team February 6, 2024 21:49
Etaash-mathamsetty
Etaash-mathamsetty approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arielj arielj merged commit c669900 into main Feb 8, 2024
9 checks passed
@arielj arielj deleted the respect-setting-disabling-autoupdater branch February 8, 2024 01:45
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Etaash-mathamsetty Etaash-mathamsetty Etaash-mathamsetty approved these changes

@flavioislima flavioislima Awaiting requested review from flavioislima flavioislima was automatically assigned from Heroic-Games-Launcher/development

@CommandMC CommandMC Awaiting requested review from CommandMC CommandMC was automatically assigned from Heroic-Games-Launcher/development

@Nocccer Nocccer Awaiting requested review from Nocccer Nocccer was automatically assigned from Heroic-Games-Launcher/development

@imLinguin imLinguin Awaiting requested review from imLinguin imLinguin was automatically assigned from Heroic-Games-Launcher/development

Assignees
No one assigned
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

Heroic checks for and spams you for updating even when you tell it not to
2 participants
@arielj @Etaash-mathamsetty