Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Set the auto fixes feature ON by default #3449

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 17, 2024

Currently, users have to know this experimental feature exists to enable it, but new users will most likely miss this (or skip it because it's experimental).

This PR changes the feature to be on by default instead and users then have to opt out if they want to not autoinstall fixes.

We haven't seen reports of this causing issues so far (but I don't know if it's because not many users are using this). I think it's a good default for a future release before promoting it from experimental.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 17, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team January 17, 2024 03:48
@arielj arielj merged commit f5159d7 into main Jan 21, 2024
9 checks passed
@arielj arielj deleted the enable-auto-fixes-by-default branch January 21, 2024 17:09
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants