[UX] Prefer using release dates from each runner #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imLinguin
added
the
pr:ready-for-review
imLinguin
requested review from
a team,
arielj,
flavioislima,
CommandMC,
Etaash-mathamsetty and
Nocccer
and removed request for
a team
imLinguin
commented
Jan 16, 2024
Comment on lines
+106
to
+108
| const releaseDate = data?._embedded.product?.globalReleaseDate?.substring( | ||
| 0, | ||
| 19 |
There was a problem hiding this comment.
substring here ensures we ommit the timezone, it creates confusing things.
e.g 1980-01-01T00:00:00+02:00 - if we didn't ignore the timezone the date might turn out to be invalid in this context: 1979-12-31
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we'll use release dates obtained from each runners API. We were already making a requests to obtain a store URL for example, so I just re-used that.
I skipped that for Amazon for now...
We have each game's release for each entry in nile's
library.json, we'd probably need to include that data in GameInfo object.Use the following Checklist if you have changed something on the Backend or Frontend: