Only try to do EOS operations on a path if there's actually a Wineprefix there #3410
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, trying to enable/disable/check the status of the EOS overlay for a game with an invalid prefix directory would lead to an error message.
We're now handling this correctly (not enabling/disabling it, always reporting that it's disabled)
Technically, this works by adding:
ValidWinePrefix
. It's an extension of thePath
type, meaning it already makes sure the string inside it is a valid path, and it now also verifies that there's auser.reg
file inside the directory it's pointing togetWinePrefixFolder
. It deduplicates some of the logic used in theenable
/disable
/isEnabled
, and now also makes sure the configured prefix path is contains a valid prefixError message before:
No error message now:
Use the following Checklist if you have changed something on the Backend or Frontend: