Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX/Linux] Open main window when clicking the Tray icon #3401

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 6, 2024

We were using the double-click event but that only works on Mac and Windows, not on Linux https://www.electronjs.org/docs/latest/api/tray#event-double-click-macos-windows

This PR changes the code to use click instead which works on all platforms.

Other electron apps like discord or slack work like this too.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 6, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team January 6, 2024 22:13
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm let me test

@Etaash-mathamsetty
Copy link
Member

Etaash-mathamsetty commented Jan 6, 2024

doesn't seem to work that well, prolly cuz click also opens context menu. double click works lmao, seems like that's the case for every application on gnome at least.

Copy link
Member

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@arielj arielj merged commit 6c811b9 into main Jan 6, 2024
9 checks passed
@arielj arielj deleted the open-window-tray-click branch January 6, 2024 23:10
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants