Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fixes file when a game is uninstalled #3398

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 6, 2024

In #3335 we are adding the feature to install known winetricks fixes. That downloads the fixes file from the https://github.com/Heroic-Games-Launcher/known-fixes repo during the installation of a game.

The problem is that we have no way or removing the file once the winetricks fix is not needed anymore, so if a game is downloaded today and a fix is not needed anymore in 2 months, if I install the game it will still run the winetricks commands.

This PR changes that so when a game is uninstalled, if a fixes file exists it gets deleted. That way, if we install the game in a few months and the fix is not needed, it won't be in the known-fixes repo and we don't download anything.

I did a small refactor cause I needed that map from runner to store and it was already defined in 3 other places


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 6, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team January 6, 2024 15:51
@arielj arielj changed the title Remove fixes file when the game uninstalled Remove fixes file when a game is uninstalled Jan 6, 2024
Copy link
Collaborator

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally the "doing the refactor" and "introducing the change" parts of this PR would be in two different commits...
but we'll squash it down when merging anyways, so that's not a huge issue

@arielj arielj merged commit 44ea197 into main Jan 6, 2024
9 checks passed
@arielj arielj deleted the delete-fix-info-on-uninstall branch January 6, 2024 21:32
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants