Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes related to "Installing Prerequisites" status #3393

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jan 5, 2024

This fixes 2 issues:

  • we were showing the Installing Prerequisites for GOG games but we don't really do that yet
  • we were setting the Installing Prerequisites status when running an exe on the prefix but never resetting that state

I also moved the Installing Prerequisites status for the Amazon setup to be displayed after the prefix is verified instead of before, to happen right before the post install step.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jan 5, 2024
@arielj arielj requested review from a team, flavioislima, CommandMC, Etaash-mathamsetty, Nocccer and imLinguin and removed request for a team January 5, 2024 23:33
Copy link
Member

@Etaash-mathamsetty Etaash-mathamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@arielj arielj merged commit d5d1482 into main Jan 6, 2024
9 checks passed
@arielj arielj deleted the prerequisites-fixes branch January 6, 2024 19:17
@Heroic-Games-Launcher Heroic-Games-Launcher locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants