[Tech] Refactor how we write to game logs #3355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use explicit calls to
writeFileSync
andappendFileSync
when we want to write game logs. This PR extracts that into more descriptive logger helper methods (initGameLog
andappendGameLog
) to simplify the usage so we can abstract the actual file name calculation and writing of the content.I'm doing this because I want to add more logging and make it all async in the future, so I want to first simplify the API.
Nothing is changed in the functionality, logs should work just the same as before.
Use the following Checklist if you have changed something on the Backend or Frontend: