-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Show a progress bar in the task bar for various app activity #3086
[UI] Show a progress bar in the task bar for various app activity #3086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. It seems it doesn't work on linux with cinnamon as the DE so I can't really test this so I'll leave this for other people to properly test it.
|
ok unfortunately it doesn't work on linux at all, but that's ok |
This one should be ready to merge after the conflicts are fixed. :) |
@flavioislima I fixed the conflicts but somehow the build is still stuck in CI 10 hours later, any idea what's wrong with it? |
Can you trigger the branch update? this will trigger the workflows. |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@0xCmdrKeen I think there is an lint issue now on main.ts. |
eb1327f
to
4226253
Compare
Sorry for the force push, looks like I may have messed up the CLA in the process. Can you pls fix it? |
can you reply again with the comment to agree with the CLA? that can probably fix it |
I have read the CLA Document and I hereby sign the CLA |
Summary
This shows a progress bar in the application's task bar icon for various background app activity, such as downloading/installing, updating, or launching a game. If any such activity starts, an indeterminate (i.e. spinning) progress bar is shown until the activity either finishes or produces some measurable progress (i.e. downloading a game), at which point the progress is shown using a determinate progress bar.
Here's a short video to demonstrate this:
Recording.2023-09-26.232214.mp4
This should work on all platforms, although there are certain limitations on Linux, see https://www.electronjs.org/docs/latest/api/browser-window#winsetprogressbarprogress-options
Details
An indeterminate progress bar is shown during the following activities:
A determinate progress bar is shown whenever a download is in progress (i.e. during installation or update), or when moving a game. Whenever a given activity finishes, the progress bar is removed again.
Checklist