Merge branch '134_and_133' into 128-fix-code-smells

Author: herbert koelman

include/logger/sinks.hpp

@@ -118,7 +118,7 @@ namespace logger {
           *
           * @param name subset name.
           */
-         virtual void set_name (const std::string &name);
+         void set_name (const std::string &name);
 
     private:
 #if __cplusplus >= 201703L
@@ -175,15 +175,15 @@ namespace logger {
          * This sink writes messages in FILE.
          *
          */
-        void write(log_level level, const char *fmt, ...) override ;
+        void write(log_level level, const char *fmt, ...) ;
 
     protected:
 
         /** Set sybsystem name and reset fixed part of the output pattern.
          *
          * @param name sink name
          */
-        void set_name(const std::string &name) override ;
+        void set_name(const std::string &name)  ;
 
         /** fill the buffer with the current date and time information
          */
@@ -301,7 +301,7 @@ namespace logger {
 
     protected:
 
-        void set_name(const std::string &name) override ;
+        void set_name(const std::string &name) ;
 
     private:
         std::string _pattern; //!< message pattern (layout)

src/syslog_sink.cpp

@@ -22,7 +22,7 @@ namespace logger {
     syslog_sink::syslog_sink(const std::string &name, const std::string &pname, log_level level, const syslog::facility &facility, int options):
             sink(name, pname, level) {
 
-        try {
+//        try {
 #ifdef DEBUG
             printf("DEBUG %s name: %s, pname: %s, level: %d, facility: %d, options: %d\n", __FUNCTION__,
                 name.c_str(),
@@ -49,9 +49,9 @@ namespace logger {
 
             openlog(program_name().c_str(), options, (int)facility.code());
 
-        } catch ( std::exception &err ){
-            throw logger_exception(err.what());
-        }
+ //       } catch ( std::exception &err ){
+ //           throw logger_exception(err.what());
+ //       }
     };
 
     syslog_sink::syslog_sink(const std::string &name, const std::string &pname, log_level level) :