Skip to content

feat: Add Codable conformance #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2023
Merged

feat: Add Codable conformance #6

merged 2 commits into from
Feb 17, 2023

Conversation

hassila
Copy link
Contributor

@hassila hassila commented Feb 17, 2023

Description

Add Codable constraint/conformance allowing automatic synthesising of Codable so Histograms can be serializes/deserialized.

Also commented out test code that was not used yet.

How Has This Been Tested?

Just added the constraint and run test suite.

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

@hassila hassila requested a review from dimlio February 17, 2023 10:27
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #6 (d83f6fd) into main (49df02b) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   97.98%   98.10%   +0.12%     
==========================================
  Files           4        4              
  Lines        1631     1631              
==========================================
+ Hits         1598     1600       +2     
+ Misses         33       31       -2     
Impacted Files Coverage Δ
Sources/Histogram/Histogram.swift 96.08% <ø> (ø)
...ests/HistogramTests/HistogramAutosizingTests.swift 100.00% <100.00%> (+3.08%) ⬆️
Impacted Files Coverage Δ
Sources/Histogram/Histogram.swift 96.08% <ø> (ø)
...ests/HistogramTests/HistogramAutosizingTests.swift 100.00% <100.00%> (+3.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49df02b...d83f6fd. Read the comment docs.

@hassila hassila merged commit 604410b into main Feb 17, 2023
@hassila hassila deleted the add-codable-conformance branch February 17, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants