Fix null text alignment returning as CENTER on HashLink
#3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the new text input, I found out that when compiling to HashLink, FlxText's
alignwould return CENTER by default (not having changed it manually), instead of LEFT. This seems to be caused by the switch statement inFlxTextAlign.fromOpenFL()treating thenullvalue as a 0, which corresponds to CENTER in OpenFL's text alignment enum (which is an abstract for Int).This PR simply adds a null check in the function, which makes it automatically return LEFT if a null alignment was passed in.