Merge pull request #67 from MuslimeKaya/main

refactor: enhance GitHub API client with commit data handling and improve caching strategy

Author: ArjinAlbay

eslint.config.mjs

@@ -11,6 +11,21 @@ const compat = new FlatCompat({
 
 const eslintConfig = [
   ...compat.extends("next/core-web-vitals", "next/typescript"),
+  {
+    rules: {
+      // Allow unused variables in catch clauses (common for error handling)
+      "@typescript-eslint/no-unused-vars": [
+        "error",
+        {
+          "argsIgnorePattern": "^_",
+          "varsIgnorePattern": "^_",
+          "caughtErrors": "none"
+        }
+      ],
+      // Allow unescaped quotes in JSX (common in descriptions)
+      "react/no-unescaped-entities": "off"
+    }
+  }
 ];
 
 export default eslintConfig;

src/app/action-required/page.tsx

@@ -41,34 +41,41 @@ export default function ActionRequiredPage() {
   const VALID_TABS = ['assigned', 'mentions', 'stale'] as const
   type ValidTab = typeof VALID_TABS[number]
 
-  const tabParam = searchParams.get('tab')
+  const tabParam = searchParams?.get('tab')
   const currentTab: ValidTab = VALID_TABS.includes(tabParam as ValidTab)
     ? (tabParam as ValidTab)
     : 'assigned'
 
   useEffect(() => {
-    refreshData().catch((error) => {
-      console.error('Failed to refresh action required data:', error)
+    refreshData().catch(() => {
+      // Silent error handling for refresh data
     })
   }, [refreshData])
 
-  const getActionItems = (type: string) => {
+  // Helper function to get action items by type
+  const getActionItems = (type: 'assigned' | 'mentions' | 'stale') => {
     switch (type) {
-      case 'assigned': return assignedItems
-      case 'mentions': return mentionItems
-      case 'stale': return staleItems
-      default: return []
+      case 'assigned':
+        return assignedItems
+      case 'mentions':
+        return mentionItems
+      case 'stale':
+        return staleItems
+      default:
+        return []
     }
   }
 
-  const isValidUrl = (url: string) => {
+  // Helper function to validate URLs
+  const isValidUrl = (url?: string): boolean => {
+    if (!url) return false
     try {
-      const parsed = new URL(url);
-      return parsed.protocol === 'https:' && parsed.hostname.includes('github.com');
+      const parsed = new URL(url)
+      return parsed.protocol === 'https:' && parsed.hostname.includes('github.com')
     } catch {
-      return false;
+      return false
     }
-  };
+  }
 
   const handleTabChange = (tab: string) => {
     if (VALID_TABS.includes(tab as ValidTab)) {
@@ -92,7 +99,7 @@ export default function ActionRequiredPage() {
   return (
     <Layout>
       <div className="max-w-7xl mx-auto p-6 space-y-6">
-        <PageHeader  />
+        <PageHeader />
 
         {/* Hero Section */}
         <div className="mb-8">
@@ -108,13 +115,13 @@ export default function ActionRequiredPage() {
         </div>
 
         {/* Action Required Tabs */}
-        <Tabs 
-          value={currentTab} 
+        <Tabs
+          value={currentTab}
           onValueChange={(value) => {
             if (VALID_TABS.includes(value as ValidTab)) {
               handleTabChange(value)
             }
-          }} 
+          }}
           className="w-full"
         >
           <TabsList className="grid w-full grid-cols-3">
@@ -327,7 +334,7 @@ export default function ActionRequiredPage() {
           </TabsContent>
         </Tabs>
       </div>
-      
+
       <SearchModal />
     </Layout>
   )

src/app/api/auth/logout/route.ts

@@ -1,4 +1,4 @@
-import {  NextResponse } from 'next/server'
+import { NextResponse } from 'next/server'
 
 export async function POST() {
   try {
@@ -24,8 +24,7 @@ export async function POST() {
     })
 
     return response
-  } catch (error) {
-    console.error('Logout error:', error)
+  } catch {
     return NextResponse.json(
       { error: 'Logout failed' },
       { status: 500 }

src/app/auth/callback/page.tsx

@@ -18,10 +18,10 @@ interface ExtendedSession {
 
 export default function AuthCallback() {
   const { data: session, status } = useSession()
-  const router = useRouter()  
+  const router = useRouter()
   const { setOrgData, setConnected, setTokenExpiry } = useAuthStore()
 
-useEffect(() => {
+  useEffect(() => {
     const extendedSession = session as ExtendedSession
     if (status === 'authenticated' && extendedSession?.accessToken && extendedSession.user) {
       try {
@@ -35,8 +35,7 @@ useEffect(() => {
         setTokenExpiry(expiryDate.toISOString())
         setConnected(true)
         router.replace('/dashboard')
-      } catch (error) {
-        console.error('Failed to set auth data:', error)
+      } catch {
         router.replace('/')
       }
     } else if (status === 'unauthenticated') {

src/app/quick-wins/page.tsx

@@ -26,7 +26,7 @@ export default function QuickWinsPage() {
     const [currentTab, setCurrentTab] = useState<ValidTab>('good-issues')
 
     useEffect(() => {
-        const tabParam = searchParams.get('tab')
+        const tabParam = searchParams?.get('tab')
         if (tabParam && VALID_TABS.includes(tabParam as ValidTab)) {
             setCurrentTab(tabParam as ValidTab)
         }
@@ -39,9 +39,7 @@ export default function QuickWinsPage() {
         goodIssuesError,
         easyFixesError,
         refreshGoodIssues,
-        refreshEasyFixes,
-     
-       
+        refreshEasyFixes
     } = useQuickWins()
 
     const handleTabChange = (tab: string) => {
@@ -50,7 +48,6 @@ export default function QuickWinsPage() {
             router.push(`/quick-wins?tab=${tab}`)
         }
     }
-   
 
     if (isLoading) {
         return (
@@ -68,8 +65,13 @@ export default function QuickWinsPage() {
     return (
         <Layout>
             <div className="max-w-7xl mx-auto p-6 space-y-6">
-                <PageHeader   />
-               
+
+                <PageHeader />
+
+                {/* Rate Limit Warning */}
+                <RateLimitWarning />
+
+
                 {/* Hero Section */}
                 <div className="mb-8">
                     <div className="flex items-center justify-between mb-2">
@@ -85,7 +87,6 @@ export default function QuickWinsPage() {
                     </p>
                 </div>
 
-              
                 {/* Quick Wins Tabs */}
                 <Tabs
                     value={currentTab}
@@ -116,7 +117,7 @@ export default function QuickWinsPage() {
                             error={goodIssuesError}
                             onRefresh={refreshGoodIssues}
                             title="Good First Issues"
-                           
+
                             emptyMessage="No good first issues found"
                         />
                     </TabsContent>
@@ -133,10 +134,8 @@ export default function QuickWinsPage() {
                     </TabsContent>
                 </Tabs>
 
-
             </div>
 
-           
         </Layout >
     )
 }

src/app/search/page.tsx

@@ -64,12 +64,12 @@ interface UserAnalytics {
     avatar_url: string;
     login: string;
     type: string;
-    bio?: string;
+    bio: string | null;
     public_repos: number;
     followers: number;
     following: number;
-    location?: string;
-    company?: string;
+    location: string | null;
+    company: string | null;
     html_url: string;
   };
   overview?: Array<UserOverviewData>;
@@ -216,6 +216,27 @@ export default function SearchPage() {
     return () => window.removeEventListener("scroll", handleScroll);
   }, [activeSection, throttle]);
 
+  const loadUserAnalytics = useCallback(async () => {
+    if (!userParam) return;
+    const requestedUser = userParam;
+
+    setLoadingAnalytics(true);
+    try {
+      const analytics = await githubAPIClient.getUserAnalytics(requestedUser);
+      // Ignore if param changed while awaiting
+      if (requestedUser !== userParam) return;
+      setUserAnalytics(analytics);
+    } catch {
+      // Fallback to null if API fails
+      if (requestedUser !== userParam) return;
+      setUserAnalytics(null);
+    } finally {
+      if (requestedUser === userParam) {
+        setLoadingAnalytics(false);
+      }
+    }
+  }, [userParam]);
+
   useEffect(() => {
     if (userParam || repoParam) {
       const query = userParam || repoParam || "";
@@ -267,7 +288,6 @@ export default function SearchPage() {
         });
       }
     } catch (error) {
-      console.error("Search error:", error);
       setSearchResults({
         repos: [],
         users: [],

src/app/settings/page.tsx

@@ -1,20 +1,20 @@
 'use client'
 
-import { useState} from 'react'
+import { useState } from 'react'
 import { Layout } from '@/components/layout/Layout'
 import { Card, CardContent, CardHeader, CardTitle } from '@/components/ui/card'
 import { Button } from '@/components/ui/button'
 import { Input } from '@/components/ui/input'
-import {  usePreferencesStore } from '@/stores'
+import { usePreferencesStore } from '@/stores'
 import { useRequireAuth } from '@/hooks/useAuth'
 import { ThemeSelector } from '@/components/theme/ThemeToggle'
+import { GitHubTokenSetup } from '@/components/common/GitHubTokenSetup'
 import { cookieUtils } from '@/lib/cookies'
 
 export default function SettingsPage() {
-  const {  isLoading, orgData } = useRequireAuth()
+  const { isLoading, orgData } = useRequireAuth()
   const { resetPreferences } = usePreferencesStore()
   const [tempOrgName, setTempOrgName] = useState(orgData?.orgName || '')
-  const [tempToken, setTempToken] = useState('')
 
   const handleClearData = () => {
     if (confirm('Tüm veriler silinecek. Emin misiniz?')) {
@@ -25,8 +25,6 @@ export default function SettingsPage() {
     }
   }
 
-
-
   if (isLoading) {
     return (
       <Layout>
@@ -42,10 +40,17 @@ export default function SettingsPage() {
 
   return (
     <Layout>
-      <div className="max-w-2xl">
-        <h2 className="text-xl font-semibold mb-4">Ayarlar</h2>
+      <div className="max-w-4xl mx-auto">
+        <h2 className="text-xl font-semibold mb-6">Ayarlar</h2>
+
+        <div className="space-y-8">
+
+          {/* GitHub API Token Setup */}
+          <section>
+            <h3 className="text-lg font-medium mb-4">🔑 GitHub API Token</h3>
+            <GitHubTokenSetup />
+          </section>
 
-        <div className="space-y-6">
           <Card>
             <CardHeader>
               <CardTitle>GitHub Bağlantısı</CardTitle>
@@ -60,19 +65,6 @@ export default function SettingsPage() {
                 />
               </div>
 
-              <div>
-                <label className="block text-sm font-medium mb-2">API Token (Opsiyonel)</label>
-                <Input
-                  type="password"
-                  value={tempToken}
-                  onChange={(e) => setTempToken(e.target.value)}
-                  placeholder="Mevcut token'ı değiştirmek için girin"
-                />
-                <p className="text-xs text-gray-500 mt-1">
-                  Token olmadan da çalışır, ancak rate limit düşük olur.
-                </p>
-              </div>
-
               <Button>
                 Kaydet
               </Button>

src/components/charts/AreaChart.tsx

@@ -26,6 +26,23 @@ export default function AreaChart({
   stack = false,
   ...chartProps
 }: AreaChartProps) {
+  // Handle empty data
+  if (!data || data.length === 0) {
+    const option: EChartsOption = {
+      title: {
+        text: 'No Data Available',
+        left: 'center',
+        top: 'middle',
+        textStyle: {
+          fontSize: 16,
+          fontWeight: 'normal',
+          color: '#9ca3af'
+        }
+      }
+    };
+    return <EChartsBase option={option} {...chartProps} />;
+  }
+
   const option: EChartsOption = {
     title: title ? {
       text: title,