Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly shut down private-bower and git-daemon #254

Open
atais opened this issue Oct 18, 2016 · 1 comment
Open

Properly shut down private-bower and git-daemon #254

atais opened this issue Oct 18, 2016 · 1 comment

Comments

@atais
Copy link

atais commented Oct 18, 2016

Hello.

I am using private-bower with slightly modified starting script for node applications (from here).

The startup is working OK, but I have a problem with quitting the application. The script currently uses:

pkill -P $PID

to kill the private-bower, but after that the git-daemon process is not stopped. Therefore if I try to start the service again it will fail due to git-daemon initialization failure.

I can add to my script to kill it (find by port, and kill) but I thought it would be nice to have private-bower to kill it, since it also invokes it. Or is it already doing that and it is my script error?

Thanks!

@atais atais changed the title Properly shut down private-bower Properly shut down private-bower and git-daemon Oct 18, 2016
@cjsfj
Copy link

cjsfj commented Oct 18, 2016

I see this same issue. The git process has to be killed after the private bower process. Would be great to have a proper unit script that can stop start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants