Fix keyboard focus loss during same-month navigation in inline mode #6054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using selectsRange, inline, and showPreviousMonths with a mismatched openToDate vs startDate, keyboard navigation within the same month would fail to properly transfer focus to the new day element. The root cause was that shouldFocusDayInline was set to false when navigating within the same month, which prevented the Day component from receiving focus. Since keyboard navigation is always user- initiated from a focused day, the destination day should always receive focus. This change simplifies the inline mode focus logic to always set shouldFocusDayInline to true during keyboard navigation, ensuring focus is properly transferred regardless of whether the month changed. Fixes #5750 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6054 +/- ##
==========================================
- Coverage 99.21% 99.21% -0.01%
==========================================
Files 30 30
Lines 3579 3574 -5
Branches 1525 1524 -1
==========================================
- Hits 3551 3546 -5
Misses 27 27
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using selectsRange, inline, and showPreviousMonths with a mismatched openToDate vs startDate, keyboard navigation within the same month would fail to properly transfer focus to the new day element.
The root cause was that shouldFocusDayInline was set to false when navigating within the same month, which prevented the Day component from receiving focus. Since keyboard navigation is always user- initiated from a focused day, the destination day should always receive focus.
This change simplifies the inline mode focus logic to always set shouldFocusDayInline to true during keyboard navigation, ensuring focus is properly transferred regardless of whether the month changed.
Fixes #5750