Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled and optimized GLM-4v-9b on Gaudi #691

Open
wants to merge 2 commits into
base: habana_main
Choose a base branch
from

Conversation

gyou2021
Copy link

@gyou2021 gyou2021 commented Jan 16, 2025

  1. Enabled the multimodal model GLM-4v-9b on Gaudi.
  2. Optimized the model:
    Removed graph recompile caused by the image and different batch size;

Example:
python examples/offline_inference_vision_language.py -m glm4v

@@ -1,10 +1,10 @@
# Adapted from

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert file mode to 100644, same for other files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other files are in different file modes. It seems that they cannot be reverted to 100644.

@@ -963,7 +961,18 @@ def _prepare_prompt(
pad=0,
dtype=torch.long,
device='cpu')

if len(multi_modal_kwargs_list

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yma11 Please take a look

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the change.

@PatrykWo PatrykWo added the question Further information is requested label Feb 4, 2025
@PatrykWo PatrykWo added New Model Issue o PR to enable a new model and removed question Further information is requested labels Feb 13, 2025
@yma11
Copy link

yma11 commented Feb 24, 2025

@gyou2021 Recently vllm has some update about multi-modal support, especially they introduced InputProcessor for each model, like [VLM] Implement merged multimodal processor for Mllama. Will it affect your implementation and will you do a update based on this?

Signed-off-by: gyou2021 <ganmei.you@intel.com>
@gyou2021 gyou2021 reopened this Mar 11, 2025
@gyou2021
Copy link
Author

@gyou2021 Recently vllm has some update about multi-modal support, especially they introduced InputProcessor for each model, like [VLM] Implement merged multimodal processor for Mllama. Will it affect your implementation and will you do a update based on this?

No. It won't affect the implementation. So no update based on this is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Model Issue o PR to enable a new model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants