Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current olusanya HEAD gives different results than v4.1.3 #540

Open
johpiip opened this issue Aug 17, 2023 · 4 comments
Open

Current olusanya HEAD gives different results than v4.1.3 #540

johpiip opened this issue Aug 17, 2023 · 4 comments

Comments

@johpiip
Copy link
Contributor

johpiip commented Aug 17, 2023

kuva

link_lengths.txt is due to #494 and it is fine, but others I can not identify.

@zptro
Copy link
Collaborator

zptro commented Aug 18, 2023

This is my best guess: 121ecc0#diff-a31f8dd24148efc83d5e06974a77a7a7d4faa374dd84d0884fb6c5c377639bd2

This changed speeds in the test network, so that should affect exactly those results if you used the test network.

@hsl-petrhaj
Copy link
Contributor

This sounds like a good explanation, does it work? @johpiip

@johpiip
Copy link
Contributor Author

johpiip commented Sep 26, 2023

Thank you both, I will check it later.

@hsl-petrhaj
Copy link
Contributor

@zptro @johpiip
I have been inverstigating the differences in the results.
Two changes occurred, both around April. The second one does not even show on the test network, only on the full network. The differences are very small, for example the volume could be like 5000 (+2), or 221 (-1).
My theory is that the changes between float32 and float64 might have in theory caused that, but it does not prevent the new version 4.1.4 from being released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants