Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quicker integration test for new commits? #498

Open
hsl-petrhaj opened this issue Apr 13, 2023 · 4 comments
Open

Quicker integration test for new commits? #498

hsl-petrhaj opened this issue Apr 13, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@hsl-petrhaj
Copy link
Contributor

Would it make sense to have some Emme-based that could be run "manually" to check if there were some functional changes made?
I think some 15-min run (0 iterations) of year 2018 base version could make sense.

@hsl-petrhaj hsl-petrhaj added the enhancement New feature or request label May 9, 2023
@johpiip
Copy link
Contributor

johpiip commented May 23, 2023

My Emme testing workflow is:

  1. Create a new Emme project by one of these two ways:
    • Run test_assignment.py and find the project, or
    • Manually using these dimensions:
      dim = {
      "scalar_matrices": 100,
      "origin_matrices": 100,
      "destination_matrices": 100,
      "full_matrices": 400,
      "scenarios": 5,
      "centroids": 20,
      "regular_nodes": 1000,
      "links": 2000,
      "turn_entries": 100,
      "transit_vehicles": 30,
      "transit_lines": 20,
      "transit_segments": 2000,
      "extra_attribute_values": 300000,
      "functions": 99,
      "operators": 5000,
      "sola_analyses": 240,
      }
  2. Use Helmet UI and make a model run where
    • Lähtödata: helmet-model-system\Scripts\tests\test_data\Base_input_data
    • Verkko: helmet-model-system\Scripts\tests\test_data\Network
    • Syöttötiedot: helmet-model-system\Scripts\tests\test_data\Scenario_input_data\2030_test

I do one model run for a working model system and then one model run for the model system that I am testing. Then I compare results either on Meld (txt files) on on Emme (assignment on network).

A test model run takes a couple of minutes, and does two iterations or so. You should not make a zero iteration run because it will only do end-assignment - unless your changes modify specifically that and you wish to test it.

Do you need more information? You can close the issue if it is clear!

@hsl-petrhaj
Copy link
Contributor Author

Just a note: The test network is now modified so that it passes the renewed network validation.
Under the test project it is the scenario number two.
@johpiip

@johpiip
Copy link
Contributor

johpiip commented Aug 17, 2023

Just a note: The test network is now modified so that it passes the renewed network validation.
Under the test project it is the scenario number two.

Which PR introduces these changes? I'm asking just to have some history here. 😊

@hsl-petrhaj
Copy link
Contributor Author

PR #521

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants