-
Notifications
You must be signed in to change notification settings - Fork 15
Feat/mlflow models from code migration vacation recommendation with bert #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gabisponciano
wants to merge
16
commits into
main
Choose a base branch
from
feat/mlflow-models-from-code-migration-vacation-recommendation-with-bert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/mlflow models from code migration vacation recommendation with bert #274
gabisponciano
wants to merge
16
commits into
main
from
feat/mlflow-models-from-code-migration-vacation-recommendation-with-bert
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-from-code approach
…ndation-with-bert' of https://github.com/HPInc/AI-Blueprints into feat/mlflow-models-from-code-migration-vacation-recommendation-with-bert
…at/mlflow-models-from-code-migration-vacation-recommendation-with-bert
…ndation-with-bert' of https://github.com/HPInc/AI-Blueprints into feat/mlflow-models-from-code-migration-vacation-recommendation-with-bert
539b308 to
10a794e
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ata-turhan
approved these changes
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
enhancement
Improvements to existing features
python
Pull requests that update python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MLflow 3.1.0 Models-from-Code Migration for Vacation Recommendation with BERT
Overview
This migration modernizes the "Vacation Recommendation with BERT" blueprint by transitioning from MLflow's legacy serialization-based model logging (
python_model) to the models-from-code approach (loader_module+data_path). This update resolves MLflow 3.1.0 compatibility issues, improves code architecture, and maintains API compatibility for vacation recommendation workflows.Key Changes
src/mlflow/structure established in PR feat: MLflow 3.1.0 Models-from-Code Migration for Vanilla RAG Blueprint #208.Universal Structure Standardization
The blueprint now follows the universal AI-Blueprints structure pattern:
Standardized Architecture
Universal Loader & Logger Synchronization
loader.pyandlogger.py: Exact copies from PR feat: MLflow 3.1.0 Models-from-Code Migration for Vanilla RAG Blueprint #208.Logger.log_model(signature, ...).src.mlflow.loader.ModelandLogger(no blueprint-specific prefixes).Technical Changes
New Architecture Components
src/mlflow/model.pyclass Model(generic name, no blueprint prefixes).predict(model_input, params)API signature for backward compatibility.src/mlflow/loader.py_load_pyfunc().Modelinstance for prediction.src/mlflow/logger.pysignatureas the first parameter:Logger.log_model(signature, ...).src/mlflow/__init__.pyModelandLogger.Notebook Updates
Enhanced Signature Handling
Signature creation now occurs in the notebook:
Artifact Management
BERT Model Artifacts Structure
The blueprint now handles BERT-specific artifacts:
Testing Strategy
Manual Testing
Quality Assurance
Code Quality
Performance Impact
Review Guidelines
Critical Review Areas
loader.pycorrectly implements models-from-code pattern.Model.predict()maintains identical signature and behavior.Deployment Considerations
python_modelapproach is incompatible with models-from-code.MODEL_ARTIFACTS_PATHenvironment variable is configured in deployment containers.Migration Status: ✅ Complete and Ready for Review
Specialized Features:
Printed page of the Streamlit web app showing evidence of successful local deployment and API testing:
Streamlit for Vacation Recommendation with BERT.pdf