Provide omega period to fitGrain #820
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@donald-e-boyce This is what it would look like if we provided the omega period to Feel free to examine the differences in the fit-grains results from this branch compared to master. They are slightly different results. |
|
I personally tried this using this example. |
psavery
force-pushed
the
fit-grain-provide-ome-period
branch
from
f27578c to
147d0fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #820 +/- ##
==========================================
- Coverage 49.26% 49.26% -0.01%
==========================================
Files 144 144
Lines 23270 23268 -2
==========================================
- Hits 11465 11463 -2
Misses 11805 11805 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
psavery
force-pushed
the
fit-grain-provide-ome-period
branch
from
147d0fc to
767250b
Compare
This does change the results of fit-grains slightly. We are currently assessing the changes. The chi-squared remained nearly the same. For one grain, it increased very slightly, and for another grain, it decreased very slightly. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
psavery
force-pushed
the
fit-grain-provide-ome-period
branch
from
767250b to
241ff2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does change the results of fit-grains slightly. We are currently assessing the changes.
The chi-squared remained nearly the same. For one grain, it increased very slightly, and for another grain, it decreased very slightly.