Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing error on timestamp value #15

Closed
laBecasse opened this issue Aug 7, 2021 · 4 comments
Closed

Parsing error on timestamp value #15

laBecasse opened this issue Aug 7, 2021 · 4 comments
Assignees

Comments

@laBecasse
Copy link

Hello, thanks for the project !

I got an error on this link : https://www.reddit.com/r/loopdaddy/comments/baguqq/first_time_poster_here_couldnt_resist_sharing_my

Failed with: json error: invalid type: floating point `1554647898`, expected i64

I discovered that it comes from "timestamp" using the following command line:

youtube-dl -J https://www.reddit.com/r/loopdaddy/comments/baguqq/first_time_poster_here_couldnt_resist_sharing_my | jq . | grep "1554647898" 
@GyrosOfWar GyrosOfWar self-assigned this Aug 8, 2021
@GyrosOfWar
Copy link
Owner

Hi, thanks for letting me know! It works when I change the type of timestamp to Option<f64>, but storing a Unix timestamp as a floating point makes me kind of uncomfortable. I'll see if I maybe write some custom parsing code or just chnage it to a float.

@twiclo
Copy link
Contributor

twiclo commented Aug 30, 2022

This works with yt-dlp and the yt-dlp feature enabled. I must once again advocate for dropping youtube-dl as they don't plan on supporting anything newer than python 3.2. This library will only get more polluted if we want to support legacy software

@stefnotch
Copy link
Contributor

Considering that youtube-dl has not gotten any updates in months, I think it'd be fair to exclusively support yt-dlp.

Even the youtubedl subreddit is apparently doing the switch, notice how the pinned posts are all about yt-dlp https://www.reddit.com/r/youtubedl/

@GyrosOfWar
Copy link
Owner

I have now reworked the library to only support yt-dlp since youtube-dl seems to not have a lot of activity lately. If it picks up again, I'm definitely open to re-adding support behind a feature flag or a runtime switch (if that's feasible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants