Added InitialClassMixin to be defined after attached event of MaterialWidget #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public MaterialWidget(Element element) { | ||
| setElement(element); | ||
| } | ||
|
|
||
| @Override | ||
| protected void onLoad() { | ||
| super.onLoad(); |
There was a problem hiding this comment.
This was left in by mistake?
Added String... for multiple instances of Pre defined class
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created InitialClassMixin to setInitialClass(String initialClass) and on MaterialWidget - Added a super contructor with params Element and String initialClass to be inject on attached event of each widget.
This will also fixed the problem on GMD integration with Errai errai/errai#170 - Preventing the errai ui to override the style classnames on Widget Injection.
Tested on Demo, Pattern and Starter showcase about the changes. 👍
Tested on gwt-material-errai 👍
Will update also the addins to have the same feature.