Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label clicking #15

Open
moromis opened this issue Sep 11, 2022 · 3 comments
Open

Fix label clicking #15

moromis opened this issue Sep 11, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@moromis
Copy link

moromis commented Sep 11, 2022

Right now, if zoomed fully in, the top couple labels do not register via singleClicking, in this screenshot:
image
The first label you can click on the y-axis is DEF vs GHI

@moromis moromis added the bug Something isn't working label Sep 11, 2022
@moromis moromis self-assigned this Sep 11, 2022
@tschaka1904
Copy link

Is this related to the wrong clicking behaviour? I noticed this behaviour:

When I double-clicking on a label on the y-axis, it does do some sort of re-ordering. But the little grey indicator triangle becomes red two rows underneath.
Screenshot 2022-09-27 at 21 34 47

@moromis
Copy link
Author

moromis commented Sep 28, 2022

@tschaka1904 Yeah, it is related. I think in general the conversion of mouse coordinates to webgl coordinates and also how it transforms with regards to the aspect ratio is wrong. I think it belies a larger underlying issue, as I think it's caused by inserting the legend component, the canvas width changing, and then never updating viz_dim.

@tschaka1904
Copy link

I can confirm the issue about the legend. Not showing it resolves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants