commit message checker passes when it should fail after pattern is removed from PR commit #63
e-mcginnis
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Workflow passes despite pattern not being present in the PRs commits.
repro steps:
This is my action definition:
Could the previous commit messages be still cached somewhere in the workflow, and end up getting passed to the
check-commit-message
workflow?a data point to support this theory: if I add
checkAllCommitMessages: 'true'
to my workflow, it fails as expected since none of the commits contain the pattern.If I then switch back to the default
checkAllCommitMessages: 'false'
it incorrectly passes.Beta Was this translation helpful? Give feedback.
All reactions