Avoid overwriting arguments w/o name or key in the PHP array (#34)

Author: mpdude

src/XmlToPhpConfigConverter.php

@@ -664,14 +664,14 @@ private function formatArgument(\DOMElement $argument): string
 
                 $itemKey = $item->getAttribute('key') ?: $item->getAttribute('name');
 
-                $itemKey = match ($item->getAttribute('key-type')) {
+                $itemKeyFormatted = match ($item->getAttribute('key-type')) {
                     'constant' => '\\'.ltrim($itemKey, '\\'),
                     'binary' => 'base64_decode('.$this->formatString($itemKey).')',
                     default => $this->formatString($itemKey),
                 };
 
                 if ($itemKey) {
-                    $items[] =  $itemKey . ' => ' . $this->formatArgument($item);
+                    $items[] =  $itemKeyFormatted . ' => ' . $this->formatArgument($item);
                 } else {
                     $items[] = $this->formatArgument($item);
                 }

tests/Fixtures/config/all_features.xml

@@ -81,6 +81,13 @@
             <argument index="1">second argument</argument>
         </service>
 
+        <!-- Service with arguments without explicit index -->
+        <service id="app.indexed_service_no_key" class="App\Service\IndexedService">
+            <argument>first argument</argument>
+            <argument>second argument</argument>
+            <argument>third argument</argument>
+        </service>
+
         <!-- Service with property injection -->
         <service id="app.newsletter_manager" class="App\Service\NewsletterManager">
             <property name="mailer" type="service" id="app.mailer" />