-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile doesn't fit for downstream packagers #17
Comments
Hello. Because it's too painful to have to maintain and synchronize multiple ways of compiling a project, so I prefer keeping just one that I can manage, than two where one cannot be maintained. |
The gentoo maintainer claimed that this did in fact used to happen, but the gentoo maintainer gave up because attempts to contribute got nowhere. Sadly, @dtschump has chosen to totally delete the repository, and delete all bug reports and pull requests in the process, so there is no way to prove that one way or the other now. This was not at all necessary -- the stated reason was a lack of familiarity with git, but even with that, the standard, correct way to handle this is to simply delete all files in the repository and commit a replacement as one giant patch. But even if that wasn't done, the other standard and correct way to handle this is to rename the repository on the GitHub UI and create a new repository while leaving the other one behind as "historical". This issue was brought up in #1 but requests to "please restore the deleted repository and I can help you smooth things over if you need help" were entirely ignored. It is now long past the 90 days where recovery of bug reports and pull requests is possible (but stitching back together the historical changelog is still possible even so). I'm not suggesting that the gmic project is trying to hide something, for the record. But apparently the Gentoo maintainer's opinion on the topic is that:
Whatever else is going on, there does seem to be a clear disconnect between what users believe they can expect from gmic, and what gmic believes it is trying to offer in the way of expectations. And this disconnect is in the realm of communications, rather than something easy to solve like code -- you can't submit a pull request to fix the former. :( |
The Makefile has always been there, from the start, as this is how I managed to compile I think you've got the wrong idea about the project's strategy. We have nothing special to hide, and the problem with the git repository was indeed a mistake on my part. It can happen. You can't master everything, especially when you have to take care of everything. It would be more constructive if you contributed rather than just criticizing.
It's not necessary to be so harsh. I'm not sure this discussion is leading to anything very constructive. |
This is not a Gentoo specific issue either way: OpenSUSE:
MacPorts: Mageia:
Homebrew:
def install
# The Makefile is not safe to run in parallel.
# Issue ref: https://github.com/dtschump/gmic/issues/406
ENV.deparallelize
# Use PLUGINDIR to avoid trying to create "/plug-ins" on Linux without GIMP.
# Disable X11 by using the values from Makefile when "/usr/X11" doesn't exist.
args = %W[
PLUGINDIR=#{buildpath}/plug-ins
USR=#{prefix}
X11_CFLAGS=-Dcimg_display=0
X11_LIBS=-lpthread
SOVERSION=#{version}
]
system "make", "lib", "cli_shared", *args
system "make", "install", *args, "PREFIX=#{prefix}"
lib.install "src/libgmic.a" (Hey, there's a broken link to an issue that homebrew submitted, which disappeared after the repository was deleted.) guix: Cygwin:
Debian: |
I applied the patches from current gentoo gmic-3.3.1.ebuild in https://github.com/LADI/gmic branch "gentoo" (the default). |
I've been packaging gmic in my Gentoo overlay for the past 9 years: https://github.com/stefantalpalaru/gentoo-overlay Every release after the first one is using CMake. Even when upstream removed its "CMakeLists.txt", I carried a fixed & improved copy in a patch. Tried to submit it upstream, but upstream decided I was not nice enough. Someone else, decidedly nicer, submitted it instead. Upstream moved it in a subdirectory, so it doesn't work out of the box :-) Anyway, after |
If the CMakeLists.txt file works, I'll move it to the root directory. I'm pretty sure this was not working for me when I moved it to the |
I confirm this works for me. |
FYI, G'MIC version 3.2.2 has been released, with the |
That's actually 3.3.2 :-) I know because I already packaged it: stefantalpalaru/gentoo-overlay@5eb4c71 |
Yes sorry, 3.3.2 indeed :) |
@stefantalpalaru works perfect here THX |
Are these fixes going to find their way back into the main Gentoo tree? I use gmic occasionally and do not want to remove it. Thanks. |
👍 |
Hello.
Would it be possible? |
I just got aware that the
src/Makefile
doesn't fit for downstream packagers i.e. on Gentoo and gmic is announced to be dropped entirely. (gentoo bug 916289)My quick search lead to some patches on gentoo - OTOH I didn't see any upstreaming back here...
So my motivation is to enable upstreaming gentoo patches
@dtschump Can you have a look at those patches and see if you could integrate them in gmic to facilitate downstream packagers life?
I also whish you could
The text was updated successfully, but these errors were encountered: