Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support region migration without specifying the region_id #4903

Open
zyy17 opened this issue Oct 30, 2024 · 2 comments
Open

Support region migration without specifying the region_id #4903

zyy17 opened this issue Oct 30, 2024 · 2 comments
Assignees
Labels
C-enhancement Category Enhancements

Comments

@zyy17
Copy link
Collaborator

zyy17 commented Oct 30, 2024

What type of enhancement is this?

API improvement

What does the enhancement do?

The current SQL admin API is:

migrate_region(region_id, from_peer, to_peer, [timeout]

When we want to execute migration between datanodes, we have to query all the region_id from information_schema and trigger the migrate_region one by one. It's not a practice API design.

We can wrap another API internally, which is:

migrate_regions(from_peer, to_peer, [timeout]

It doesn't need significant changes for the original implementation of region migration and provides the new operator-friendly API.

Implementation challenges

No response

@zyy17 zyy17 added the C-enhancement Category Enhancements label Oct 30, 2024
@zyy17 zyy17 changed the title Support region migration without specifying the region_id. Support region migration without specifying the region_id Oct 30, 2024
@fengjiachun
Copy link
Collaborator

PTAL @WenyXu

@killme2008
Copy link
Contributor

I take this issue, it's easy to implement it.

@killme2008 killme2008 self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements
Projects
None yet
Development

No branches or pull requests

3 participants