Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL for the new region server #2373

Open
waynexia opened this issue Sep 13, 2023 · 1 comment
Open

REPL for the new region server #2373

waynexia opened this issue Sep 13, 2023 · 1 comment
Labels
C-enhancement Category Enhancements

Comments

@waynexia
Copy link
Member

What type of enhancement is this?

Refactor

What does the enhancement do?

REPL is bound in the universal greptime binary. It's a convenient tools for debugging datanode.

After we migrated to region server #2364, datanode now only handles queries in logical plan, and only for one region. The previous REPL impl is broken as it still passes SQL and table queries. We should make some necessary changes to make REPL work again.

Implementation challenges

  • Emit logical plan instead of SQL
  • Connect to meta server to retrieve table route info.
  • Do partial query on regions that exist in the connected datanode
@waynexia waynexia added the C-enhancement Category Enhancements label Sep 13, 2023
@MichaelScofield
Copy link
Collaborator

For the new REPL, I think we can simply support these two features: 1. connect to Frontend only, and 2. submit SQLs. In this way, we'll get a cli client to talk to greptimedb in grpc interface, good for testing grpc service, and useful when there're no other cli client like mysql or psql.

@MichaelScofield MichaelScofield added the good first issue Good for newcomers label Apr 11, 2024
@evenyag evenyag removed the good first issue Good for newcomers label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements
Projects
None yet
Development

No branches or pull requests

3 participants