Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing "size" method for Accumulator #1710

Open
MichaelScofield opened this issue Jun 3, 2023 · 0 comments
Open

Implementing "size" method for Accumulator #1710

MichaelScofield opened this issue Jun 3, 2023 · 0 comments
Labels
C-enhancement Category Enhancements C-performance Category Performance

Comments

@MichaelScofield
Copy link
Collaborator

What type of enhancement is this?

Performance

What does the enhancement do?

The size method in DataFusion's Accumulator is important for some statistics and performance optimization (like "size hint"). See its doc:

/// Allocated size required for this accumulator, in bytes, including `Self`.
/// Allocated means that for internal containers such as `Vec`, the `capacity` should be used
/// not the `len`

Currently it's always 0.

Implementation challenges

No response

@MichaelScofield MichaelScofield added C-enhancement Category Enhancements C-performance Category Performance labels Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements C-performance Category Performance
Projects
None yet
Development

No branches or pull requests

1 participant