Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates more tests from duckdb #1168

Open
1 of 9 tasks
killme2008 opened this issue Mar 14, 2023 · 8 comments
Open
1 of 9 tasks

Migrates more tests from duckdb #1168

killme2008 opened this issue Mar 14, 2023 · 8 comments
Labels
C-enhancement Category Enhancements good first issue Good for newcomers help wanted Extra attention is needed tracking-issue A tracking issue for a feature.

Comments

@killme2008
Copy link
Contributor

killme2008 commented Mar 14, 2023

What type of enhancement is this?

Tech debt reduction, Other

What does the enhancement do?

We already migrate some tests from duckdb's SQL test: https://github.com/duckdb/duckdb/tree/master/test/sql. And it already helps us figure out some bugs such as #790 #791 #759 etc.

But there are still many tests that still need to be migrated. Let's create an issue to track them:

I list the main tests. Of course, our current tests still miss many cases; they must also be migrated.

Implementation challenges

No response

@killme2008 killme2008 added C-enhancement Category Enhancements good first issue Good for newcomers help wanted Extra attention is needed Size: XL tracking-issue A tracking issue for a feature. labels Mar 14, 2023
@WenyXu
Copy link
Member

WenyXu commented Mar 14, 2023

Could we introduce the Sqllogictest-rs framework to perform tests?

@killme2008
Copy link
Contributor Author

We already have sqlness https://docs.greptime.com/developer-guide/tests/sqlness-test

@WenyXu
Copy link
Member

WenyXu commented Mar 14, 2023

We already have sqlness https://docs.greptime.com/developer-guide/tests/sqlness-test

I see. I thought we could utilize the existing sqllogictest test files, but we still need to modify them.

@Gump9
Copy link
Contributor

Gump9 commented Jul 3, 2023

Hello!I'm new to here.Can I have a try to migrate select tests?What test cases can I refer to that have been migrated? where are they?

@MichaelScofield
Copy link
Collaborator

@Gump9 welcome! The test cases for select are here

@Gump9
Copy link
Contributor

Gump9 commented Jul 3, 2023

@Gump9 welcome! The test cases for select are here

tks a lot

@Gump9
Copy link
Contributor

Gump9 commented Jul 3, 2023

@Gump9 welcome! The test cases for select are here

Excuse me again, could you tell me where are the tests that have been migrated to gretimeDB,i notice that the join part has been migrated,and how can i learn this part in greptimeDB.sry,i'm really new and unfamiliar with many things😭

@MichaelScofield
Copy link
Collaborator

@Gump9 We are expecting the duckdb's test cases, the SQLs, to be ported into our sqlness tests. To start, you can learn everything about sqlness tests here. Then you can check the duckdb's test cases, to see if the SQL is already present in our sqlness tests. If not, just add that case to our sqlness tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements good first issue Good for newcomers help wanted Extra attention is needed tracking-issue A tracking issue for a feature.
Projects
None yet
Development

No branches or pull requests

5 participants