-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: link configuration file options to GitHub #1051
Conversation
WalkthroughThe updates to the Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Deploying greptime-docs with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- docs/nightly/en/reference/command-lines.md (3 hunks)
- docs/nightly/en/user-guide/operations/configuration.md (2 hunks)
- docs/nightly/zh/reference/command-lines.md (3 hunks)
- docs/nightly/zh/user-guide/operations/configuration.md (2 hunks)
- docs/v0.5/en/user-guide/operations/configuration.md (1 hunks)
- docs/v0.6/en/user-guide/operations/configuration.md (1 hunks)
- docs/v0.7/en/user-guide/operations/configuration.md (1 hunks)
- docs/v0.8/en/user-guide/operations/configuration.md (1 hunks)
Files skipped from review due to trivial changes (6)
- docs/nightly/en/user-guide/operations/configuration.md
- docs/nightly/zh/user-guide/operations/configuration.md
- docs/v0.5/en/user-guide/operations/configuration.md
- docs/v0.6/en/user-guide/operations/configuration.md
- docs/v0.7/en/user-guide/operations/configuration.md
- docs/v0.8/en/user-guide/operations/configuration.md
Additional context used
LanguageTool
docs/nightly/en/reference/command-lines.md
[uncategorized] ~60-~60: Loose punctuation mark.
Context: ...onds. ---metasrv-addrs <METASRV_ADDR>
: Metasrv address list; - `--node-id <NOD...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~78-~78: Loose punctuation mark.
Context: ...sfalse
. ---env-prefix <ENV_PREFIX>
: The prefix of environment variables, de...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~82-~82: Loose punctuation mark.
Context: ...ut in seconds. ---selector <SELECTOR>
: You can refer [selector-type](/contribu...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~97-~97: Loose punctuation mark.
Context: ...sfalse
. ---env-prefix <ENV_PREFIX>
: The prefix of environment variables, de...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~101-~101: Loose punctuation mark.
Context: ...imeout in seconds. ---influxdb-enable
: Whether to enable InfluxDB protocol in ...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~118-~118: Loose punctuation mark.
Context: ...tart --help ``` ---node-id <NODE_ID>
: Flownode's id - `--rpc-addr <RPC_ADDR>`...(UNLIKELY_OPENING_PUNCTUATION)
Additional comments not posted (14)
docs/nightly/zh/reference/command-lines.md (7)
3-4
: LGTM!The introductory lines about the Greptime CLI are clear and concise.
5-13
: LGTM!The installation instructions for the Greptime CLI are clear and easy to follow.
Line range hint
14-46
: LGTM!The list of available commands and options for the Greptime CLI is comprehensive and well-documented.
47-65
: LGTM!The list of options for the
datanode
subcommand is detailed and well-documented.
68-86
: LGTM!The list of options for the
metasrv
subcommand is detailed and well-documented.
87-109
: LGTM!The list of options for the
frontend
subcommand is detailed and well-documented.
Line range hint
110-198
: LGTM!The sections on
flownode
andstandalone
subcommand options, configuration examples, and upgrade instructions are detailed and well-documented.docs/nightly/en/reference/command-lines.md (7)
3-4
: LGTM!The introductory lines about the Greptime CLI are clear and concise.
5-13
: LGTM!The installation instructions for the Greptime CLI are clear and easy to follow.
Line range hint
14-46
: LGTM!The list of available commands and options for the Greptime CLI is comprehensive and well-documented.
Tools
LanguageTool
[uncategorized] ~60-~60: Loose punctuation mark.
Context: ...onds. ---metasrv-addrs <METASRV_ADDR>
: Metasrv address list; - `--node-id <NOD...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~78-~78: Loose punctuation mark.
Context: ...sfalse
. ---env-prefix <ENV_PREFIX>
: The prefix of environment variables, de...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~82-~82: Loose punctuation mark.
Context: ...ut in seconds. ---selector <SELECTOR>
: You can refer [selector-type](/contribu...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~97-~97: Loose punctuation mark.
Context: ...sfalse
. ---env-prefix <ENV_PREFIX>
: The prefix of environment variables, de...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~101-~101: Loose punctuation mark.
Context: ...imeout in seconds. ---influxdb-enable
: Whether to enable InfluxDB protocol in ...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~118-~118: Loose punctuation mark.
Context: ...tart --help ``` ---node-id <NODE_ID>
: Flownode's id - `--rpc-addr <RPC_ADDR>`...(UNLIKELY_OPENING_PUNCTUATION)
47-65
: LGTM!The list of options for the
datanode
subcommand is detailed and well-documented.Tools
LanguageTool
[uncategorized] ~60-~60: Loose punctuation mark.
Context: ...onds. ---metasrv-addrs <METASRV_ADDR>
: Metasrv address list; - `--node-id <NOD...(UNLIKELY_OPENING_PUNCTUATION)
68-86
: LGTM!The list of options for the
metasrv
subcommand is detailed and well-documented.Tools
LanguageTool
[uncategorized] ~78-~78: Loose punctuation mark.
Context: ...sfalse
. ---env-prefix <ENV_PREFIX>
: The prefix of environment variables, de...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~82-~82: Loose punctuation mark.
Context: ...ut in seconds. ---selector <SELECTOR>
: You can refer [selector-type](/contribu...(UNLIKELY_OPENING_PUNCTUATION)
87-109
: LGTM!The list of options for the
frontend
subcommand is detailed and well-documented.Tools
LanguageTool
[uncategorized] ~97-~97: Loose punctuation mark.
Context: ...sfalse
. ---env-prefix <ENV_PREFIX>
: The prefix of environment variables, de...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~101-~101: Loose punctuation mark.
Context: ...imeout in seconds. ---influxdb-enable
: Whether to enable InfluxDB protocol in ...(UNLIKELY_OPENING_PUNCTUATION)
Line range hint
110-198
: LGTM!The sections on
flownode
andstandalone
subcommand options, configuration examples, and upgrade instructions are detailed and well-documented.Tools
LanguageTool
[uncategorized] ~60-~60: Loose punctuation mark.
Context: ...onds. ---metasrv-addrs <METASRV_ADDR>
: Metasrv address list; - `--node-id <NOD...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~78-~78: Loose punctuation mark.
Context: ...sfalse
. ---env-prefix <ENV_PREFIX>
: The prefix of environment variables, de...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~82-~82: Loose punctuation mark.
Context: ...ut in seconds. ---selector <SELECTOR>
: You can refer [selector-type](/contribu...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~97-~97: Loose punctuation mark.
Context: ...sfalse
. ---env-prefix <ENV_PREFIX>
: The prefix of environment variables, de...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~101-~101: Loose punctuation mark.
Context: ...imeout in seconds. ---influxdb-enable
: Whether to enable InfluxDB protocol in ...(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~118-~118: Loose punctuation mark.
Context: ...tart --help ``` ---node-id <NODE_ID>
: Flownode's id - `--rpc-addr <RPC_ADDR>`...(UNLIKELY_OPENING_PUNCTUATION)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- docs/nightly/en/user-guide/operations/configuration.md (6 hunks)
- docs/nightly/zh/user-guide/operations/configuration.md (2 hunks)
Files skipped from review as they are similar to previous changes (2)
- docs/nightly/en/user-guide/operations/configuration.md
- docs/nightly/zh/user-guide/operations/configuration.md
@killme2008 The options has been put back into the document, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's Changed in this PR
close #1043
let the configuration document as an overview about how to setup configuration:
Checklist
summary.yml
matches the current document structure when you changed the document structure.Summary by CodeRabbit
data_home
instead ofmax_inflight_tasks
.