Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: link configuration file options to GitHub #1051

Merged
merged 7 commits into from
Jul 15, 2024

Conversation

nicecui
Copy link
Collaborator

@nicecui nicecui commented Jul 11, 2024

What's Changed in this PR

close #1043

let the configuration document as an overview about how to setup configuration:

  • Moved the command line options to the command line documentation
  • Linked the configuration file options to Github
  • Also fixed the wrong description about environment variable

Checklist

  • Please confirm that all corresponding versions of the documents have been revised.
  • Please ensure that the content in summary.yml matches the current document structure when you changed the document structure.
  • This change requires follow-up update in localized docs.

Summary by CodeRabbit

  • Documentation
    • Enhanced Greptime CLI reference documentation with detailed options and examples.
    • Refined GreptimeDB configuration guide for better clarity and order of precedence.
    • Updated configuration examples across multiple versions to illustrate the use of environment variables for setting data_home instead of max_inflight_tasks.

@nicecui nicecui requested a review from a team as a code owner July 11, 2024 12:12
Copy link
Contributor

coderabbitai bot commented Jul 11, 2024

Walkthrough

The updates to the configuration.md files for GreptimeDB streamline the documentation of configuration settings, clarify the order of precedence, include configuration examples, and detail how settings can be specified via command-line options, configuration files, and environment variables. These changes aim to enhance the clarity and usability of the configuration documentation for both English and Chinese audiences.

Changes

File Path Change Summary
docs/nightly/en/user-guide/operations/configuration.md Rephrased for clarity, updated precedence order, added configuration examples, and detailed specification methods.
docs/nightly/zh/user-guide/operations/configuration.md Refined configuration options, emphasized hierarchy, and updated descriptions for various settings.

Assessment against linked issues

Objective Addressed Explanation
Split the configuration doc by modules or nodes (#1043)
Review the configuration for v0.9 release (#1043)

Poem

In the land of Greptime's lore,
Configuration's a guide we adore.
With clarity and order, examples to see,
Settings made simple, for you and me.
Command-line, files, and variables too,
GreptimeDB config, all fresh and new.
🌟✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nicecui nicecui changed the title refactor: link configuration file options to Github refactor: link configuration file options to GitHub Jul 11, 2024
Copy link

cloudflare-workers-and-pages bot commented Jul 11, 2024

Deploying greptime-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f6ec26e
Status: ✅  Deploy successful!
Preview URL: https://b18c365b.greptime-docs.pages.dev
Branch Preview URL: https://refactor-configuration.greptime-docs.pages.dev

View logs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bbe2608 and 57b0ec7.

Files selected for processing (8)
  • docs/nightly/en/reference/command-lines.md (3 hunks)
  • docs/nightly/en/user-guide/operations/configuration.md (2 hunks)
  • docs/nightly/zh/reference/command-lines.md (3 hunks)
  • docs/nightly/zh/user-guide/operations/configuration.md (2 hunks)
  • docs/v0.5/en/user-guide/operations/configuration.md (1 hunks)
  • docs/v0.6/en/user-guide/operations/configuration.md (1 hunks)
  • docs/v0.7/en/user-guide/operations/configuration.md (1 hunks)
  • docs/v0.8/en/user-guide/operations/configuration.md (1 hunks)
Files skipped from review due to trivial changes (6)
  • docs/nightly/en/user-guide/operations/configuration.md
  • docs/nightly/zh/user-guide/operations/configuration.md
  • docs/v0.5/en/user-guide/operations/configuration.md
  • docs/v0.6/en/user-guide/operations/configuration.md
  • docs/v0.7/en/user-guide/operations/configuration.md
  • docs/v0.8/en/user-guide/operations/configuration.md
Additional context used
LanguageTool
docs/nightly/en/reference/command-lines.md

[uncategorized] ~60-~60: Loose punctuation mark.
Context: ...onds. - --metasrv-addrs <METASRV_ADDR>: Metasrv address list; - `--node-id <NOD...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~78-~78: Loose punctuation mark.
Context: ...s false. - --env-prefix <ENV_PREFIX>: The prefix of environment variables, de...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~82-~82: Loose punctuation mark.
Context: ...ut in seconds. - --selector <SELECTOR>: You can refer [selector-type](/contribu...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~97-~97: Loose punctuation mark.
Context: ...s false. - --env-prefix <ENV_PREFIX>: The prefix of environment variables, de...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~101-~101: Loose punctuation mark.
Context: ...imeout in seconds. - --influxdb-enable: Whether to enable InfluxDB protocol in ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~118-~118: Loose punctuation mark.
Context: ...tart --help ``` - --node-id <NODE_ID>: Flownode's id - `--rpc-addr <RPC_ADDR>`...

(UNLIKELY_OPENING_PUNCTUATION)

Additional comments not posted (14)
docs/nightly/zh/reference/command-lines.md (7)

3-4: LGTM!

The introductory lines about the Greptime CLI are clear and concise.


5-13: LGTM!

The installation instructions for the Greptime CLI are clear and easy to follow.


Line range hint 14-46: LGTM!

The list of available commands and options for the Greptime CLI is comprehensive and well-documented.


47-65: LGTM!

The list of options for the datanode subcommand is detailed and well-documented.


68-86: LGTM!

The list of options for the metasrv subcommand is detailed and well-documented.


87-109: LGTM!

The list of options for the frontend subcommand is detailed and well-documented.


Line range hint 110-198: LGTM!

The sections on flownode and standalone subcommand options, configuration examples, and upgrade instructions are detailed and well-documented.

docs/nightly/en/reference/command-lines.md (7)

3-4: LGTM!

The introductory lines about the Greptime CLI are clear and concise.


5-13: LGTM!

The installation instructions for the Greptime CLI are clear and easy to follow.


Line range hint 14-46: LGTM!

The list of available commands and options for the Greptime CLI is comprehensive and well-documented.

Tools
LanguageTool

[uncategorized] ~60-~60: Loose punctuation mark.
Context: ...onds. - --metasrv-addrs <METASRV_ADDR>: Metasrv address list; - `--node-id <NOD...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~78-~78: Loose punctuation mark.
Context: ...s false. - --env-prefix <ENV_PREFIX>: The prefix of environment variables, de...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~82-~82: Loose punctuation mark.
Context: ...ut in seconds. - --selector <SELECTOR>: You can refer [selector-type](/contribu...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~97-~97: Loose punctuation mark.
Context: ...s false. - --env-prefix <ENV_PREFIX>: The prefix of environment variables, de...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~101-~101: Loose punctuation mark.
Context: ...imeout in seconds. - --influxdb-enable: Whether to enable InfluxDB protocol in ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~118-~118: Loose punctuation mark.
Context: ...tart --help ``` - --node-id <NODE_ID>: Flownode's id - `--rpc-addr <RPC_ADDR>`...

(UNLIKELY_OPENING_PUNCTUATION)


47-65: LGTM!

The list of options for the datanode subcommand is detailed and well-documented.

Tools
LanguageTool

[uncategorized] ~60-~60: Loose punctuation mark.
Context: ...onds. - --metasrv-addrs <METASRV_ADDR>: Metasrv address list; - `--node-id <NOD...

(UNLIKELY_OPENING_PUNCTUATION)


68-86: LGTM!

The list of options for the metasrv subcommand is detailed and well-documented.

Tools
LanguageTool

[uncategorized] ~78-~78: Loose punctuation mark.
Context: ...s false. - --env-prefix <ENV_PREFIX>: The prefix of environment variables, de...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~82-~82: Loose punctuation mark.
Context: ...ut in seconds. - --selector <SELECTOR>: You can refer [selector-type](/contribu...

(UNLIKELY_OPENING_PUNCTUATION)


87-109: LGTM!

The list of options for the frontend subcommand is detailed and well-documented.

Tools
LanguageTool

[uncategorized] ~97-~97: Loose punctuation mark.
Context: ...s false. - --env-prefix <ENV_PREFIX>: The prefix of environment variables, de...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~101-~101: Loose punctuation mark.
Context: ...imeout in seconds. - --influxdb-enable: Whether to enable InfluxDB protocol in ...

(UNLIKELY_OPENING_PUNCTUATION)


Line range hint 110-198: LGTM!

The sections on flownode and standalone subcommand options, configuration examples, and upgrade instructions are detailed and well-documented.

Tools
LanguageTool

[uncategorized] ~60-~60: Loose punctuation mark.
Context: ...onds. - --metasrv-addrs <METASRV_ADDR>: Metasrv address list; - `--node-id <NOD...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~78-~78: Loose punctuation mark.
Context: ...s false. - --env-prefix <ENV_PREFIX>: The prefix of environment variables, de...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~82-~82: Loose punctuation mark.
Context: ...ut in seconds. - --selector <SELECTOR>: You can refer [selector-type](/contribu...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~97-~97: Loose punctuation mark.
Context: ...s false. - --env-prefix <ENV_PREFIX>: The prefix of environment variables, de...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~101-~101: Loose punctuation mark.
Context: ...imeout in seconds. - --influxdb-enable: Whether to enable InfluxDB protocol in ...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~118-~118: Loose punctuation mark.
Context: ...tart --help ``` - --node-id <NODE_ID>: Flownode's id - `--rpc-addr <RPC_ADDR>`...

(UNLIKELY_OPENING_PUNCTUATION)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 57b0ec7 and f6ec26e.

Files selected for processing (2)
  • docs/nightly/en/user-guide/operations/configuration.md (6 hunks)
  • docs/nightly/zh/user-guide/operations/configuration.md (2 hunks)
Files skipped from review as they are similar to previous changes (2)
  • docs/nightly/en/user-guide/operations/configuration.md
  • docs/nightly/zh/user-guide/operations/configuration.md

@nicecui
Copy link
Collaborator Author

nicecui commented Jul 15, 2024

@killme2008 The options has been put back into the document, PTAL

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicecui nicecui merged commit 238d114 into main Jul 15, 2024
6 checks passed
@nicecui nicecui deleted the refactor/configuration branch July 15, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split the configuration doc and review them again
3 participants