add version argument for writing gene expression to hdf5 #2161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the current package has introduced
version
argument, along with other new arguments in theaddMatToArrow
function,ArchR/R/ArrowWrite.R
Lines 105 to 126 in 65968a4
but the higher-level function
addGeneExpressionMatrix
does not support passing those new arguments.This pull request aims to provide the option to use the hdf5 style of the old version (version = 1).