Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version argument for writing gene expression to hdf5 #2161

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

szcf-weiya
Copy link

I noticed that the current package has introduced version argument, along with other new arguments in the addMatToArrow function,

ArchR/R/ArrowWrite.R

Lines 105 to 126 in 65968a4

.addMatToArrow <- function(
mat = NULL,
ArrowFile = NULL,
Group = NULL,
binarize = FALSE,
addRowSums = FALSE,
addColSums = FALSE,
addRowMeans = FALSE,
addRowVars = FALSE,
addColMeansLog2 = FALSE, #New
addRowMeansLog2 = FALSE, #New
addRowVarsLog2 = FALSE,
addRowMeansGeo = FALSE, #New
addRowVarsGeo = FALSE, #New
addRowSumsBinary = FALSE, #New
addColSumsBinary = FALSE, #New
addRowMeansLog2Norm = FALSE, #New
addRowVarsLog2Norm = FALSE, #New
scaleTo = 10000, #New
colSm = NULL, #New
logFile = NULL,
version = 2 #New

but the higher-level function addGeneExpressionMatrix does not support passing those new arguments.

This pull request aims to provide the option to use the hdf5 style of the old version (version = 1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant