Add prop to render help trigger in SearchForm component #4734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SearchForm` is almost always used with some special query syntax that that users may not know, or may not always remember. That means that almost always there is a help button associated to the `SearchForm`. So far the help button was rendered outside the `SearchForm` component, usually too far away from the text input as to still remain some context. This commit let us render a help button inside the text input, helping users to associate that help with the text that they are supposed to write in that input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchFormis almost always used with some special query syntax that that users may not know, or may not always remember. That means that almost always there is a help button associated to theSearchForm. So far the help button was rendered outside theSearchFormcomponent, usually too far away from the text input as to still remain some context.This commit let us render a help button inside the text input, helping users to associate that help with the text that they are supposed to write in that input.
The prop is optional, so other consumers of
SearchFormwill work as they were working before.