Add intersection benchmark

Author: TrueDoctor

Cargo.lock

@@ -0,0 +1,29 @@
+use criterion::{black_box, criterion_group, criterion_main, Criterion};
+use glam::DVec2;
+use path_bool::*;
+
+pub fn criterion_benchmark(crit: &mut Criterion) {
+	crit.bench_function("intersect 1", |bench| bench.iter(|| path_segment_intersection(&a(), &b(), true, &EPS)));
+	crit.bench_function("intersect 2", |bench| bench.iter(|| path_segment_intersection(&c(), &d(), true, &EPS)));
+}
+
+criterion_group!(benches, criterion_benchmark);
+criterion_main!(benches);
+
+fn a() -> PathSegment {
+	PathSegment::Cubic(
+		DVec2::new(458.37027, 572.165771),
+		DVec2::new(428.525848, 486.720093),
+		DVec2::new(368.618805, 467.485992),
+		DVec2::new(273.0, 476.0),
+	)
+}
+fn b() -> PathSegment {
+	PathSegment::Cubic(DVec2::new(273.0, 476.0), DVec2::new(419.0, 463.0), DVec2::new(481.741198, 514.692273), DVec2::new(481.333333, 768.0))
+}
+fn c() -> PathSegment {
+	PathSegment::Cubic(DVec2::new(273.0, 476.0), DVec2::new(107.564178, 490.730591), DVec2::new(161.737915, 383.575775), DVec2::new(0.0, 340.0))
+}
+fn d() -> PathSegment {
+	PathSegment::Cubic(DVec2::new(0.0, 340.0), DVec2::new(161.737914, 383.575765), DVec2::new(107.564182, 490.730587), DVec2::new(273.0, 476.0))
+}

libraries/path-bool/benches/path_segment_intersection.rs

@@ -45,6 +45,7 @@ pub fn extend_bounding_box(bounding_box: Option<AaBb>, point: Vector) -> AaBb {
 	}
 }
 
+#[inline(never)]
 pub fn bounding_box_max_extent(bounding_box: &AaBb) -> f64 {
 	(bounding_box.right - bounding_box.left).max(bounding_box.bottom - bounding_box.top)
 }

libraries/path-bool/src/aabb.rs

@@ -18,6 +18,7 @@ struct IntersectionSegment {
 	bounding_box: AaBb,
 }
 
+#[inline(never)]
 fn subdivide_intersection_segment(int_seg: &IntersectionSegment) -> [IntersectionSegment; 2] {
 	let (seg0, seg1) = split_segment_at(&int_seg.seg, 0.5);
 	let mid_param = (int_seg.start_param + int_seg.end_param) / 2.0;
@@ -37,6 +38,7 @@ fn subdivide_intersection_segment(int_seg: &IntersectionSegment) -> [Intersectio
 	]
 }
 
+#[inline(never)]
 fn path_segment_to_line_segment(seg: &PathSegment) -> [Vector; 2] {
 	match seg {
 		PathSegment::Line(start, end) => [*start, *end],
@@ -46,6 +48,7 @@ fn path_segment_to_line_segment(seg: &PathSegment) -> [Vector; 2] {
 	}
 }
 
+#[inline(never)]
 fn intersection_segments_overlap(seg0: &IntersectionSegment, seg1: &IntersectionSegment) -> bool {
 	match (&seg0.seg, &seg1.seg) {
 		(PathSegment::Line(start0, end0), PathSegment::Line(start1, end1)) => {
@@ -57,6 +60,7 @@ fn intersection_segments_overlap(seg0: &IntersectionSegment, seg1: &Intersection
 	}
 }
 
+#[inline(never)]
 pub fn segments_equal(seg0: &PathSegment, seg1: &PathSegment, point_epsilon: f64) -> bool {
 	match (*seg0, *seg1) {
 		(PathSegment::Line(start0, end0), PathSegment::Line(start1, end1)) => vectors_equal(start0, start1, point_epsilon) && vectors_equal(end0, end1, point_epsilon),
@@ -80,8 +84,6 @@ pub fn segments_equal(seg0: &PathSegment, seg1: &PathSegment, point_epsilon: f64
 }
 
 pub fn path_segment_intersection(seg0: &PathSegment, seg1: &PathSegment, endpoints: bool, eps: &Epsilons) -> Vec<[f64; 2]> {
-	eprintln!("intersecting:");
-	dbg!(seg0, seg1);
 	// dbg!(&seg0, &seg1, endpoints);
 	if let (PathSegment::Line(start0, end0), PathSegment::Line(start1, end1)) = (seg0, seg1) {
 		if let Some(st) = line_segment_intersection([*start0, *end0], [*start1, *end1], eps.param) {
@@ -116,6 +118,7 @@ pub fn path_segment_intersection(seg0: &PathSegment, seg1: &PathSegment, endpoin
 
 	while !pairs.is_empty() {
 		next_pairs.clear();
+		dbg!("checking pairs");
 
 		for (seg0, seg1) in pairs.iter() {
 			if segments_equal(&seg0.seg, &seg1.seg, eps.point) {
@@ -130,6 +133,7 @@ pub fn path_segment_intersection(seg0: &PathSegment, seg1: &PathSegment, endpoin
 				let line_segment0 = path_segment_to_line_segment(&seg0.seg);
 				let line_segment1 = path_segment_to_line_segment(&seg1.seg);
 				if let Some(st) = line_segment_intersection(line_segment0, line_segment1, eps.param) {
+					dbg!("pushing param");
 					params.push([lerp(seg0.start_param, seg0.end_param, st.0), lerp(seg1.start_param, seg1.end_param, st.1)]);
 				}
 			} else {
@@ -165,3 +169,36 @@ pub fn path_segment_intersection(seg0: &PathSegment, seg1: &PathSegment, endpoin
 
 	params
 }
+
+#[cfg(test)]
+mod test {
+	use super::*;
+	use glam::DVec2;
+
+	#[test]
+	fn intersect_cubic_slow_first() {
+		path_segment_intersection(&a(), &b(), true, &crate::EPS);
+	}
+	#[test]
+	fn intersect_cubic_slow_second() {
+		path_segment_intersection(&c(), &d(), true, &crate::EPS);
+	}
+
+	fn a() -> PathSegment {
+		PathSegment::Cubic(
+			DVec2::new(458.37027, 572.165771),
+			DVec2::new(428.525848, 486.720093),
+			DVec2::new(368.618805, 467.485992),
+			DVec2::new(273.0, 476.0),
+		)
+	}
+	fn b() -> PathSegment {
+		PathSegment::Cubic(DVec2::new(273.0, 476.0), DVec2::new(419.0, 463.0), DVec2::new(481.741198, 514.692273), DVec2::new(481.333333, 768.0))
+	}
+	fn c() -> PathSegment {
+		PathSegment::Cubic(DVec2::new(273.0, 476.0), DVec2::new(107.564178, 490.730591), DVec2::new(161.737915, 383.575775), DVec2::new(0.0, 340.0))
+	}
+	fn d() -> PathSegment {
+		PathSegment::Cubic(DVec2::new(0.0, 340.0), DVec2::new(161.737914, 383.575765), DVec2::new(107.564182, 490.730587), DVec2::new(273.0, 476.0))
+	}
+}

libraries/path-bool/src/intersection_path_segment.rs

@@ -15,8 +15,10 @@ mod vector;
 #[cfg(test)]
 mod visual_tests;
 
-pub use path_boolean::{path_boolean, FillRule, PathBooleanOperation};
+pub use intersection_path_segment::path_segment_intersection;
+pub use path_boolean::{path_boolean, FillRule, PathBooleanOperation, EPS};
 pub use path_data::{path_from_path_data, path_to_path_data};
+pub use path_segment::PathSegment;
 
 #[cfg(test)]
 mod test {

libraries/path-bool/src/lib.rs

@@ -8,6 +8,7 @@ pub type LineSegment = [Vector; 2];
 
 const COLLINEAR_EPS: f64 = f64::EPSILON * 64.0;
 
+#[inline(never)]
 pub fn line_segment_intersection([p1, p2]: LineSegment, [p3, p4]: LineSegment, eps: f64) -> Option<(f64, f64)> {
 	// https://en.wikipedia.org/wiki/Intersection_(geometry)#Two_line_segments
 

libraries/path-bool/src/line_segment.rs

@@ -44,7 +44,7 @@ pub enum FillRule {
 const INTERSECTION_TREE_DEPTH: usize = 8;
 const POINT_TREE_DEPTH: usize = 8;
 
-const EPS: Epsilons = Epsilons {
+pub const EPS: Epsilons = Epsilons {
 	point: 1e-6,
 	linear: 1e-4,
 	param: 1e-8,