Hide EditorApi and add a comment describing unresolved Import node input types

Author: adamgerhant

editor/src/messages/portfolio/document/graph_operation/utility_types.rs

@@ -876,6 +876,11 @@ impl<'a> ModifyInputsContext<'a> {
 				can_reconnect = false
 			}
 
+			// Do not reconnect to EditorApi network input in the document network.
+			if network_path.is_empty() && reconnect_to_input.as_ref().is_some_and(|reconnect| matches!(reconnect, NodeInput::Network { .. })) {
+				can_reconnect = false
+			}
+
 			// Only reconnect if the output index for the node to be deleted is 0
 			if can_reconnect && reconnect_to_input.is_some() {
 				// None means to use reconnect_to_input, which can be safely unwrapped

editor/src/messages/portfolio/document/node_graph/node_graph_message_handler.rs

@@ -1144,7 +1144,17 @@ impl NodeGraphMessageHandler {
 				(node_input, frontend_graph_input)
 			});
 
-			let primary_input = inputs.next().filter(|(input, _)| input.is_exposed()).map(|(_, input_type)| input_type);
+			let primary_input = inputs
+				.next()
+				.filter(|(input, _)| {
+					// Don't show EditorApi input to nodes like "Text" in the document network
+					if document_network == network && matches!(input, NodeInput::Network { .. }) {
+						false
+					} else {
+						input.is_exposed()
+					}
+				})
+				.map(|(_, input_type)| input_type);
 			let exposed_inputs = inputs
 				.filter(|(input, _)| input.is_exposed() && !(matches!(input, NodeInput::Network { .. }) && document_network == network))
 				.map(|(_, input_type)| input_type)
@@ -1356,6 +1366,7 @@ impl NodeGraphMessageHandler {
 			let mut import_node_outputs = Vec::new();
 			for (index, definition_name) in import_names.into_iter().enumerate() {
 				let (connected, connected_index) = connected_node_to_output_lookup.get(&(network.imports_metadata.0, index)).unwrap_or(&(Vec::new(), Vec::new())).clone();
+				// TODO: Non exposed inputs are not added to the inputs_source_map, fix `pub fn document_node_types(&self) -> ResolvedDocumentNodeTypes`
 				let input_type = self.resolved_types.inputs.get(&Source { node: self.network.clone(), index }).cloned();
 
 				let frontend_data_type = if let Some(input_type) = input_type.clone() {

node-graph/interpreted-executor/src/dynamic_executor.rs

@@ -85,6 +85,7 @@ impl DynamicExecutor {
 
 	pub fn document_node_types(&self) -> ResolvedDocumentNodeTypes {
 		let mut resolved_document_node_types = ResolvedDocumentNodeTypes::default();
+		// TODO: Non exposed inputs are not added to the inputs_source_map, so they are not included in the resolved_document_node_types. The type is still available in the typing_context. This only affects the UI only import node.
 		for (source, &(protonode_id, protonode_index)) in self.tree.inputs_source_map() {
 			let Some(node_io) = self.typing_context.type_of(protonode_id) else { continue };
 			let Some(ty) = [&node_io.input].into_iter().chain(&node_io.parameters).nth(protonode_index) else {
@@ -206,7 +207,7 @@ impl BorrowTree {
 			ConstructionArgs::Value(value) => {
 				let upcasted = UpcastNode::new(value.to_owned());
 				let node = Box::new(upcasted) as TypeErasedBox<'_>;
-				let node = NodeContainer::new(node);
+				let node: std::rc::Rc<NodeContainer> = NodeContainer::new(node);
 				self.store_node(node, id);
 			}
 			ConstructionArgs::Inline(_) => unimplemented!("Inline nodes are not supported yet"),