Code review

Author: Keavon

editor/src/messages/tool/common_functionality/snapping/layer_snapper.rs

@@ -89,6 +89,7 @@ impl LayerSnapper {
 
 	pub fn free_snap_paths(&mut self, snap_data: &mut SnapData, point: &SnapCandidatePoint, snap_results: &mut SnapResults, config: SnapTypeConfiguration) {
 		self.collect_paths(snap_data, !config.use_existing_candidates);
+
 		let document = snap_data.document;
 		let normals = document.snapping_state.target_enabled(SnapTarget::Path(PathSnapTarget::NormalToPath));
 		let tangents = document.snapping_state.target_enabled(SnapTarget::Path(PathSnapTarget::TangentToPath));
@@ -286,21 +287,25 @@ fn snap_normals(path: &SnapCandidatePath, normals: bool, point: &SnapCandidatePo
 	}
 }
 
-// TODO: Snap rectangles and ellipses to ellipses tangents, find out why point.neighbors is empty while drawing rectangles and ellipses
+// TODO: Snap rectangles and ellipses to ellipses tangents.
+// TODO: Find out why `point.neighbors` is empty while drawing rectangles and ellipses.
 fn snap_tangents(path: &SnapCandidatePath, tangents: bool, point: &SnapCandidatePoint, tolerance: f64, snap_results: &mut SnapResults) {
 	if !tangents || point.neighbors.len() != 1 {
 		return;
 	}
+
 	let neighbor = point.neighbors[0];
+
 	for t in path.document_curve.tangents_to_point(neighbor) {
 		let tangent_point = path.document_curve.evaluate(TValue::Parametric(t));
 
-		if let Some(closest_point) = closest_point_along_line(neighbor, point.document_point, &path.document_curve, tolerance, 20) {
+		if closest_point_along_line(neighbor, point.document_point, &path.document_curve, tolerance, 20).is_some() {
 			let tangent = (tangent_point - neighbor).normalize();
 			let offset = (point.document_point - tangent_point).dot(tangent);
 			let snap_to = tangent_point + tangent * offset;
 
 			let distance = snap_to.distance(point.document_point);
+
 			snap_results.points.push(SnappedPoint {
 				snapped_point_document: snap_to,
 				source: point.source,
@@ -316,21 +321,22 @@ fn snap_tangents(path: &SnapCandidatePath, tangents: bool, point: &SnapCandidate
 		}
 	}
 }
+
 fn closest_point_along_line(start: DVec2, end: DVec2, curve: &Bezier, tolerance: f64, max_iterations: usize) -> Option<DVec2> {
 	let mut closest_point = None;
 	let mut closest_distance = f64::INFINITY;
 
 	for i in 0..=max_iterations {
 		let t = i as f64 / max_iterations as f64;
 
-		let curve_point = curve.evaluate(TValue::Parametric(t));
-		let tangent = curve.tangent(TValue::Parametric(t));
-		if tangent.length_squared() == 0.0 {
+		if curve.tangent(TValue::Parametric(t)).length_squared() == 0. {
 			continue;
 		}
 
+		let curve_point = curve.evaluate(TValue::Parametric(t));
+
 		let line_direction = end - start;
-		if line_direction.length_squared() == 0.0 {
+		if line_direction.length_squared() == 0. {
 			break;
 		}
 
@@ -345,6 +351,7 @@ fn closest_point_along_line(start: DVec2, end: DVec2, curve: &Bezier, tolerance:
 			closest_point = Some(projected_point);
 		}
 	}
+
 	if closest_distance < tolerance { closest_point } else { None }
 }